Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 16645007: MIPS: Skip some conditional deopts for Div/Mul when all uses are truncating. (Closed)

Created:
7 years, 6 months ago by kilvadyb
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Skip some conditional deopts for Div/Mul when all uses are truncating. Port r15060 (8cdd204) Original commit message: - set "can be minus zero" flag properly so minus-zero checks are skipped - skip "integer result?" check in division code when uses are truncating - drive-by cleanup: consolidated computation of kCanOverflow flag for Add/Sub into range inference phase BUG=v8:2132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 6 months ago (2013-06-11 16:56:43 UTC) #1
Paul Lind
LGTM, I'll land this for you.
7 years, 6 months ago (2013-06-11 17:34:49 UTC) #2
Paul Lind
7 years, 6 months ago (2013-06-11 17:42:34 UTC) #3
Committed as r15070.

Powered by Google App Engine
This is Rietveld 408576698