Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664483003: [runtime] Make %FunctionGetScript and %FunctionGetSourceCode robust. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Make %FunctionGetScript and %FunctionGetSourceCode robust. R=jarin@chromium.org BUG=chromium:582703 LOG=n Committed: https://crrev.com/e4e418f3effe5bc8f306085c805cc695dfa3498f Cr-Commit-Position: refs/heads/master@{#33693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/runtime/runtime-function.cc View 2 chunks +12 lines, -7 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-582703.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-03 05:06:44 UTC) #1
Benedikt Meurer
Hey Jaro, Let's make clusterfuzz happy. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-03 05:15:21 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-03 05:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664483003/1
4 years, 10 months ago (2016-02-03 05:29:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 06:00:59 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 06:01:27 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e4e418f3effe5bc8f306085c805cc695dfa3498f
Cr-Commit-Position: refs/heads/master@{#33693}

Powered by Google App Engine
This is Rietveld 408576698