Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1664443002: Compile out Java IME logs using a static boolean. (Closed)

Created:
4 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 10 months ago
Reviewers:
Changwan Ryu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile out Java IME logs using a static boolean. We were relying on Proguard to strip out Log.d, but we run Proguard -dontoptimize on some release build configurations, which means nothing is stripped. BUG=583143 Committed: https://crrev.com/45044228c2d41acc658b435d079d462d88fafb90 Cr-Commit-Position: refs/heads/master@{#373188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -34 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 18 chunks +27 lines, -19 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 14 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
aelias_OOO_until_Jul13
Hi changwan@, PTAL.
4 years, 10 months ago (2016-02-02 21:12:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664443002/1
4 years, 10 months ago (2016-02-02 22:50:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 00:22:55 UTC) #7
Changwan Ryu
lgtm
4 years, 10 months ago (2016-02-03 06:09:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664443002/1
4 years, 10 months ago (2016-02-03 06:09:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 06:14:30 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 06:15:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45044228c2d41acc658b435d079d462d88fafb90
Cr-Commit-Position: refs/heads/master@{#373188}

Powered by Google App Engine
This is Rietveld 408576698