Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 166443008: Files.app: Use createDirectoryContents_ method during search. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Use createDirectoryContents_ method during search. Previously, during typing a search query on the drive, Files.app uses DirectoryContents#createForDirectory method. It does not handle FakeEntries so it causes an exception if a user typing a search query in the drive special folders. This CL replace the method with createDirectoryContents_, which is a caller of the createForDirectory method and can handle FakeEntries. BUG=344459 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/foreground/js/directory_contents.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/directory_model.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
hirono
PTAL the CL? Thanks!
6 years, 10 months ago (2014-02-19 08:39:46 UTC) #1
yoshiki
lgtm
6 years, 10 months ago (2014-02-19 08:51:47 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-19 09:00:22 UTC) #3
hirono
On 2014/02/19 08:51:47, yoshiki wrote: > lgtm Thanks!
6 years, 10 months ago (2014-02-19 09:00:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/166443008/1
6 years, 10 months ago (2014-02-19 09:00:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/166443008/1
6 years, 10 months ago (2014-02-19 14:53:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/166443008/1
6 years, 10 months ago (2014-02-19 15:27:23 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 19:35:29 UTC) #8
Message was sent while issue was closed.
Change committed as 252044

Powered by Google App Engine
This is Rietveld 408576698