Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 166443005: Fix parenting of touch editing handles and quick menu (Closed)

Created:
6 years, 10 months ago by mohsen
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix parenting of touch editing handles and quick menu Previously, TouchEditableImplAura returned the root window as its native view which was used as the parent of touch editing handles and quick menu. This caused some positioning problems in external display. Here, TouchEditableImplAura is changed to return the browser window as its native view (similar to Views::Textfield's current behavior). BUG=339627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mohsen
Please take a look...
6 years, 10 months ago (2014-02-18 20:14:46 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-02-19 16:43:43 UTC) #2
mohsen
The CQ bit was checked by mohsen@chromium.org
6 years, 10 months ago (2014-02-19 16:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/166443005/1
6 years, 10 months ago (2014-02-19 16:58:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 19:41:19 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=266470
6 years, 10 months ago (2014-02-19 19:41:19 UTC) #6
mohsen
The CQ bit was checked by mohsen@chromium.org
6 years, 10 months ago (2014-02-19 19:51:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/166443005/1
6 years, 10 months ago (2014-02-19 19:51:22 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 21:38:41 UTC) #9
Message was sent while issue was closed.
Change committed as 252099

Powered by Google App Engine
This is Rietveld 408576698