Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6016)

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 166443004: Add frame color option to packaged app windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/app_window.idl
diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl
index fb13c1303b44f8dd79ad80228e10d11fd16cce52..73fec640649dd8627e0248310d74f5d369f97416 100644
--- a/chrome/common/extensions/api/app_window.idl
+++ b/chrome/common/extensions/api/app_window.idl
@@ -13,6 +13,12 @@ namespace app.window {
long? height;
};
+ // TODO(benwells): document this once we are happy with it.
+ [nodoc] dictionary FrameOptions {
+ DOMString? type;
+ DOMString? color;
+ };
+
// State of a window: normal, fullscreen, maximized, minimized.
enum State { normal, fullscreen, maximized, minimized };
@@ -76,6 +82,10 @@ namespace app.window {
// to disable this style on nested elements.
DOMString? frame;
+ // TODO(benwells): Fix the IDL parsing so this can be:
+ // (DOMString or FrameOptions)? frame.
+ [nodoc] FrameOptions? frameOptions;
+
// Size and position of the content in the window (excluding the titlebar).
// If an id is also specified and a window with a matching id has been shown
// before, the remembered bounds of the window will be used instead.
@@ -232,6 +242,10 @@ namespace app.window {
// Is the window always on top?
static boolean isAlwaysOnTop();
+ // Accessors for testing.
+ [nodoc] boolean hasFrameColor;
+ [nodoc] long frameColor;
+
// Set whether the window should stay above most other windows. Requires the
// <code>"alwaysOnTopWindows"</code> permission.
static void setAlwaysOnTop(boolean alwaysOnTop);

Powered by Google App Engine
This is Rietveld 408576698