Issue 166443003: Move CSSCalcExpressionNode and subclasses to the oilpan heap.

Issue 166443003: Move CSSCalcExpressionNode and subclasses to the oilpan heap. (Closed)

Created:
6 years, 10 months ago by wibling-chromium

Modified:
6 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Chromium), jochen (gone - plz use gerrit), Mads Ager (chromium), tkent, zerny-chromium, Erik Corry, haraken

CC:
blink-reviews, ed+blinkwatch_opera.com, yurys+blink_chromium.org, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rune+blink, dglazkov+blink, Mikhail, abarth-chromium, dstockwell, Timothy Loh, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, loislo+blink_chromium.org, Steve Block, dino_apple.com, Inactive, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move CSSCalcExpressionNode and subclasses to the oilpan heap. Also had to remove explicit from one of the RawPtr constructors to allow for conversion of RawPtr<CSSCalcPrimitiveValue> -> RawPtr<CSSCalcExpressionNode>. This also required to add a more explicit assignment constructor to avoid ambiguities. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, jochen@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167279

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review feedback #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -43 lines)			Patch
M	Source/core/animation/AnimatableLength.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/animation/AnimatableLength.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSCalculationValue.h	View		5 chunks	+12 lines, -9 lines	0 comments	Download
M	Source/core/css/CSSCalculationValue.cpp	View	1	13 chunks	+45 lines, -22 lines	0 comments	Download
M	Source/core/css/CSSCalculationValueTest.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/wtf/RawPtr.h	View		2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/166443003/diff/1/Source/core/css/CSSCalculationValue.cpp File Source/core/css/CSSCalculationValue.cpp (right): https://codereview.chromium.org/166443003/diff/1/Source/core/css/CSSCalculationValue.cpp#newcode276 Source/core/css/CSSCalculationValue.cpp:276: explicit CSSCalcPrimitiveValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> value, bool isInteger) Drop explicit. https://codereview.chromium.org/166443003/diff/1/Source/core/css/CSSCalculationValue.cpp#newcode549 ...

6 years, 10 months ago (2014-02-14 15:15:10 UTC) #3

wibling-chromium

Thanks for the reviews! https://codereview.chromium.org/166443003/diff/1/Source/core/css/CSSCalculationValue.cpp File Source/core/css/CSSCalculationValue.cpp (right): https://codereview.chromium.org/166443003/diff/1/Source/core/css/CSSCalculationValue.cpp#newcode276 Source/core/css/CSSCalculationValue.cpp:276: explicit CSSCalcPrimitiveValue(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> value, bool isInteger) ...

6 years, 10 months ago (2014-02-17 08:15:09 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/166443003/110001

6 years, 10 months ago (2014-02-17 09:00:38 UTC) #7

Message was sent while issue was closed.

Change committed as 167279

Expand Messages | Collapse Messages