Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1664413002: PPC: [generators] Implement Generator.prototype.return. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [generators] Implement Generator.prototype.return. Port dbd86408134e67551c1e66c3a7484abb628b95f7 Original commit message: Note: This is currently only used by yield*, we still need to support it in other places (such as for-of loops). It can be used manually of course. (This CL does not touch the full-codegen implementation of yield* because that code is already dead. The yield* desugaring already supports return and doesn't need to be touched.) R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:3566 LOG=y Committed: https://crrev.com/bedb3344aa43ebf95676c82ed050f5cb03eba623 Cr-Commit-Position: refs/heads/master@{#33754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-04 21:43:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664413002/1
4 years, 10 months ago (2016-02-04 21:43:29 UTC) #3
michael_dawson
On 2016/02/04 21:43:29, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-04 21:55:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 22:00:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664413002/1
4 years, 10 months ago (2016-02-04 22:08:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 22:10:58 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 22:11:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bedb3344aa43ebf95676c82ed050f5cb03eba623
Cr-Commit-Position: refs/heads/master@{#33754}

Powered by Google App Engine
This is Rietveld 408576698