Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: tools/observatory_tool.py

Issue 1664403002: Fix unnecessary Observatory rebuilds in Flutter (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/observatory.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/observatory_tool.py
diff --git a/tools/observatory_tool.py b/tools/observatory_tool.py
index fb3f364b354f9fad96e81029993cbcb9e706b605..606289b766ed393534d1e36acbb852007f41b87f 100755
--- a/tools/observatory_tool.py
+++ b/tools/observatory_tool.py
@@ -29,6 +29,14 @@ IGNORE_PATTERNS = shutil.ignore_patterns(
usage = """observatory_tool.py [options]"""
+def CreateTimestampFile(options):
+ if options.stamp != '':
+ dir_name = os.path.dirname(options.stamp)
+ if dir_name != '':
+ if not os.path.exists(dir_name):
+ os.mkdir(dir_name)
+ open(options.stamp, 'w').close()
+
def BuildArguments():
result = argparse.ArgumentParser(usage=usage)
result.add_argument("--package-root", help="package root", default=None)
@@ -38,6 +46,7 @@ def BuildArguments():
result.add_argument("--command", help="[get, build, deploy]", default=None)
result.add_argument("--silent", help="silence all output", default=None)
result.add_argument("--sdk", help="Use prebuilt sdk", default=None)
+ result.add_argument("--stamp", help="Write a stamp file", default='')
return result
def ProcessOptions(options, args):
@@ -205,7 +214,11 @@ def main():
args[0] = os.path.abspath(args[0])
# Pub must be run from the project's root directory.
ChangeDirectory(options.directory)
- return ExecuteCommand(options, args)
+ result = ExecuteCommand(options, args)
+ if result == 0:
+ CreateTimestampFile(options)
+ return result
+
if __name__ == '__main__':
sys.exit(main());
« no previous file with comments | « runtime/observatory/observatory.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698