Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1664403002: Fix unnecessary Observatory rebuilds in Flutter (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, ricow1, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix unnecessary Observatory rebuilds in Flutter The cause of the rebuilds was that in v 1.14, running `pub build` modifies pubspec.lock file (v 1.13 and below did not do this, bug filed #25688) resulting in unnecessary rebuilds. - Remove two output build rules because they cause issues with Make. - Write our own stamp file and use that instead of pubspec.lock. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/3bf51e01386a0b0d12dc6655a69b58e3f67fcf02

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M runtime/observatory/BUILD.gn View 7 chunks +4 lines, -5 lines 0 comments Download
M runtime/observatory/observatory.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/observatory_tool.py View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 10 months ago (2016-02-04 21:16:58 UTC) #3
zra
lgtm with small fix https://codereview.chromium.org/1664403002/diff/1/tools/observatory_tool.py File tools/observatory_tool.py (right): https://codereview.chromium.org/1664403002/diff/1/tools/observatory_tool.py#newcode218 tools/observatory_tool.py:218: if result < 0: if ...
4 years, 10 months ago (2016-02-04 21:20:18 UTC) #4
Cutch
https://codereview.chromium.org/1664403002/diff/1/tools/observatory_tool.py File tools/observatory_tool.py (right): https://codereview.chromium.org/1664403002/diff/1/tools/observatory_tool.py#newcode218 tools/observatory_tool.py:218: if result < 0: On 2016/02/04 21:20:18, zra wrote: ...
4 years, 10 months ago (2016-02-04 21:23:17 UTC) #5
Cutch
4 years, 10 months ago (2016-02-04 21:23:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3bf51e01386a0b0d12dc6655a69b58e3f67fcf02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698