Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1852)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166433004: Android: re-add perf test summary. (Closed)

Created:
6 years, 10 months ago by bulach
Modified:
6 years, 10 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android: re-add perf test summary. This was lost when we unified the perf test runner in crrev.com/217665. BUG=343900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251650

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M build/android/pylib/perf/test_runner.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
ptal
6 years, 10 months ago (2014-02-14 15:34:28 UTC) #1
rmcilroy
One suggestion, but otherwise lgtm https://codereview.chromium.org/166433004/diff/1/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/166433004/diff/1/build/android/pylib/perf/test_runner.py#newcode91 build/android/pylib/perf/test_runner.py:91: continue Do we want ...
6 years, 10 months ago (2014-02-14 15:48:40 UTC) #2
bulach
thanks ross! good idea, added.. CQing.. https://codereview.chromium.org/166433004/diff/1/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/166433004/diff/1/build/android/pylib/perf/test_runner.py#newcode91 build/android/pylib/perf/test_runner.py:91: continue On 2014/02/14 ...
6 years, 10 months ago (2014-02-14 16:08:13 UTC) #3
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-14 16:08:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/166433004/60001
6 years, 10 months ago (2014-02-14 16:09:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 18:49:03 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264392
6 years, 10 months ago (2014-02-14 18:49:03 UTC) #7
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-17 09:37:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/166433004/60001
6 years, 10 months ago (2014-02-17 09:37:15 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 10:55:07 UTC) #10
Message was sent while issue was closed. 
Change committed as 251650

Powered by Google App Engine
This is Rietveld 408576698