Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 1664273002: Turn on service tracing for all service tests. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn on service tracing for all service tests. Minor refactor of hasPausedAtStart. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/246c15257f2a70f93b9baff8037b3a2f9ed0eb0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -32 lines) Patch
M runtime/observatory/tests/service/test_helper.dart View 2 chunks +4 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-02-04 17:55:53 UTC) #2
Cutch
lgtm
4 years, 10 months ago (2016-02-04 17:57:55 UTC) #3
turnidge
4 years, 10 months ago (2016-02-04 17:58:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
246c15257f2a70f93b9baff8037b3a2f9ed0eb0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698