Issue 1664263002: JSON API cleanups

Issue 1664263002: JSON API cleanups (Closed)

Created:
4 years, 10 months ago by ethannicholas

Modified:
4 years, 10 months ago

Reviewers:
jcgregorio, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

JSON API cleanups GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1664263002 Committed: https://skia.googlesource.com/skia/+/7471c780d48afd4dc02ed45c60a2fd2efa9e5a84

Patch Set 1 #

Patch Set 2 : reverted unintentional revert of Josh's changes :-) #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -100 lines)			Patch
M	tools/json/SkJSONCanvas.h	View	1	4 chunks	+8 lines, -1 line	0 comments	Download
M	tools/json/SkJSONCanvas.cpp	View	1	19 chunks	+58 lines, -27 lines	0 comments	Download
M	tools/json/SkJSONRenderer.cpp	View		19 chunks	+115 lines, -72 lines	0 comments	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664263002/20001

4 years, 10 months ago (2016-02-04 18:12:14 UTC) #7

commit-bot: I haz the power

4 years, 10 months ago (2016-02-04 18:37:53 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7471c780d48afd4dc02ed45c60a2fd2efa9e5a84

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages