Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: net/cert/internal/extended_key_usage_unittest.cc

Issue 1664243002: Using == instead of Equals for der::Input comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/certificate_policies.cc ('k') | net/cert/internal/signature_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/extended_key_usage_unittest.cc
diff --git a/net/cert/internal/extended_key_usage_unittest.cc b/net/cert/internal/extended_key_usage_unittest.cc
index fd6ad5a1ff4c849e495a80dac270359336f41116..525698d30696cd672ac09471558fe0a2b67d7ca0 100644
--- a/net/cert/internal/extended_key_usage_unittest.cc
+++ b/net/cert/internal/extended_key_usage_unittest.cc
@@ -16,7 +16,7 @@ namespace {
// Helper method to check if an EKU is present in a std::vector of EKUs.
bool HasEKU(const std::vector<der::Input>& list, const der::Input& eku) {
for (const auto& oid : list) {
- if (oid.Equals(eku))
+ if (oid == eku)
return true;
}
return false;
@@ -62,7 +62,7 @@ TEST(ExtendedKeyUsageTest, RepeatedOid) {
EXPECT_TRUE(ParseEKUExtension(extension, &ekus));
EXPECT_EQ(2u, ekus.size());
for (const auto& eku : ekus) {
- EXPECT_TRUE(eku.Equals(ServerAuth()));
+ EXPECT_EQ(ServerAuth(), eku);
}
}
« no previous file with comments | « net/cert/internal/certificate_policies.cc ('k') | net/cert/internal/signature_algorithm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698