net/cert/asn1_util.cc - Issue 1664243002: Using == instead of Equals for der::Input comparison.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/asn1_util.cc

Issue 1664243002: Using == instead of Equals for der::Input comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using non-class equality. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/asn1_util.cc

diff --git a/net/cert/asn1_util.cc b/net/cert/asn1_util.cc

index 315ca75e648c527f500af42178a5a54fd68773ed..6b0b71d9024faf44703546602b4c8569bd8adc7a 100644

--- a/net/cert/asn1_util.cc

+++ b/net/cert/asn1_util.cc

@@ -185,7 +185,7 @@ bool ExtractCRLURLsFromDERCert(base::StringPiece cert,

// CRL Distribution Points extension.

static const uint8_t kCRLDistributionPointsOID[] = {0x55, 0x1d, 0x1f};

- if (!oid.Equals(der::Input(kCRLDistributionPointsOID)))

+ if (oid != der::Input(kCRLDistributionPointsOID))

continue;

// critical

« no previous file with comments | « no previous file | net/cert/internal/certificate_policies.cc » ('j') | net/cert/internal/test_helpers.h » ('J')