Issue 16642003: add a default value for return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16642003: add a default value for return value (Closed)

Created:
7 years, 6 months ago by dcarney

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

add a default value for return value R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15024

Patch Set 2 : comments addressed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -33 lines)			Patch
M	include/v8.h	View	1	7 chunks	+20 lines, -11 lines	0 comments	Download
M	src/arguments.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		4 chunks	+12 lines, -8 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		4 chunks	+11 lines, -6 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		5 chunks	+11 lines, -8 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/16642003/diff/2001/src/arguments.h File src/arguments.h (right): https://codereview.chromium.org/16642003/diff/2001/src/arguments.h#newcode256 src/arguments.h:256: values[T::kReturnValueDefaultValueIndex] = How do we ...

7 years, 6 months ago (2013-06-10 07:24:00 UTC) #1

dcarney

7 years, 6 months ago (2013-06-10 07:41:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r15024 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16642003: add a default value for return value (Closed)

Description

Patch Set 1 : #

Patch Set 2 : comments addressed #

Messages