Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1664193002: Upstream ChromeBrowserStateManagerImpl. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
droger
CC:
chromium-reviews, grt+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, sdefresne+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstream-chrome-browser-state-impl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ChromeBrowserStateManagerImpl. BUG=None Committed: https://crrev.com/dbea0911a81f7a7b1116469e6f890ad992577569 Cr-Commit-Position: refs/heads/master@{#373591}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -82 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 3 chunks +3 lines, -7 lines 0 comments Download
A + ios/chrome/browser/browser_state/chrome_browser_state_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc View 1 chunk +260 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_removal_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state_metrics/browser_state_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 2 chunks +1 line, -1 line 0 comments Download
M ios/chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/ios_chrome_signin_status_metrics_provider_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/signin/signin_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/glue/sync_start_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/provider/ios_provider_chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ios/public/provider/chrome/browser/browser_state/chrome_browser_state_manager.h View 1 chunk +0 lines, -52 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1664823003 Patch 20001

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-04 13:17:16 UTC) #2
droger
lgtm https://codereview.chromium.org/1664193002/diff/1/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h File ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h (right): https://codereview.chromium.org/1664193002/diff/1/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h#newcode12 ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h:12: #include "base/memory/scoped_vector.h" Should be scoped_ptr.h
4 years, 10 months ago (2016-02-04 13:27:11 UTC) #3
sdefresne
https://codereview.chromium.org/1664193002/diff/1/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h File ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h (right): https://codereview.chromium.org/1664193002/diff/1/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h#newcode12 ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h:12: #include "base/memory/scoped_vector.h" On 2016/02/04 at 13:27:11, droger wrote: > ...
4 years, 10 months ago (2016-02-04 16:09:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1664193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1664193002/20001
4 years, 10 months ago (2016-02-04 19:34:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 19:40:23 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 19:41:44 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dbea0911a81f7a7b1116469e6f890ad992577569
Cr-Commit-Position: refs/heads/master@{#373591}

Powered by Google App Engine
This is Rietveld 408576698