third_party/WebKit/Source/web/LinkHighlightImpl.cpp - Issue 1663963004: Blink Compositor Animation: Use PassOwnPtr in CompositorFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

Issue 1663963004: Blink Compositor Animation: Use PassOwnPtr in CompositorFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@curves

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

index 20b0fe7762fee89c47393ac1d12969143aa10823..115cfc13ca596d10f0e0483312cba7f782d8f0d6 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

@@ -84,7 +84,7 @@ LinkHighlightImpl::LinkHighlightImpl(Node* node, WebViewImpl* owningWebViewImpl)

m_clipLayer->setTransformOrigin(WebFloatPoint3D());

m_clipLayer->addChild(m_contentLayer->layer());

if (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {

- m_compositorPlayer = adoptPtr(CompositorFactory::current().createAnimationPlayer());

+ m_compositorPlayer = CompositorFactory::current().createAnimationPlayer();

ASSERT(m_compositorPlayer);

m_compositorPlayer->setAnimationDelegate(this);

if (m_owningWebViewImpl->linkHighlightsTimeline())

@@ -295,7 +295,7 @@ void LinkHighlightImpl::startHighlightAnimationIfNeeded()

m_contentLayer->layer()->setOpacity(startOpacity);

- OwnPtr<CompositorFloatAnimationCurve> curve = adoptPtr(CompositorFactory::current().createFloatAnimationCurve());

+ OwnPtr<CompositorFloatAnimationCurve> curve = CompositorFactory::current().createFloatAnimationCurve();

curve->add(CompositorFloatKeyframe(0, startOpacity));

// Make sure we have displayed for at least minPreFadeDuration before starting to fade out.

@@ -305,7 +305,7 @@ void LinkHighlightImpl::startHighlightAnimationIfNeeded()

// For layout tests we don't fade out.

curve->add(CompositorFloatKeyframe(fadeDuration + extraDurationRequired, layoutTestMode() ? startOpacity : 0));

- OwnPtr<CompositorAnimation> animation = adoptPtr(CompositorFactory::current().createAnimation(*curve, CompositorAnimation::TargetPropertyOpacity));

+ OwnPtr<CompositorAnimation> animation = CompositorFactory::current().createAnimation(*curve, CompositorAnimation::TargetPropertyOpacity);

m_contentLayer->layer()->setDrawsContent(true);

if (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled())