third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp - Issue 1663963004: Blink Compositor Animation: Use PassOwnPtr in CompositorFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

Issue 1663963004: Blink Compositor Animation: Use PassOwnPtr in CompositorFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@curves

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp ('k') | third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

index d1e7faf7df191e3e2d107aefab9b5158eef65151..cc9add19f89505bc60e57f3a0f5e778ab86c4725 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp

@@ -105,7 +105,7 @@ class AnimationPlayerForTesting : public CompositorAnimationPlayerClient {

public:

AnimationPlayerForTesting()

{

- m_compositorPlayer = adoptPtr(CompositorFactory::current().createAnimationPlayer());

+ m_compositorPlayer = CompositorFactory::current().createAnimationPlayer();

}

CompositorAnimationPlayer* compositorPlayer() const override

@@ -120,13 +120,13 @@ TEST_F(GraphicsLayerTest, updateLayerShouldFlattenTransformWithAnimations)

{

ASSERT_FALSE(m_platformLayer->hasActiveAnimation());

- OwnPtr<CompositorFloatAnimationCurve> curve = adoptPtr(CompositorFactory::current().createFloatAnimationCurve());

+ OwnPtr<CompositorFloatAnimationCurve> curve = CompositorFactory::current().createFloatAnimationCurve();

curve->add(CompositorFloatKeyframe(0.0, 0.0));

- OwnPtr<CompositorAnimation> floatAnimation(adoptPtr(CompositorFactory::current().createAnimation(*curve, CompositorAnimation::TargetPropertyOpacity)));

+ OwnPtr<CompositorAnimation> floatAnimation(CompositorFactory::current().createAnimation(*curve, CompositorAnimation::TargetPropertyOpacity));

int animationId = floatAnimation->id();

if (RuntimeEnabledFeatures::compositorAnimationTimelinesEnabled()) {

- OwnPtr<CompositorAnimationTimeline> compositorTimeline = adoptPtr(CompositorFactory::current().createAnimationTimeline());

+ OwnPtr<CompositorAnimationTimeline> compositorTimeline = CompositorFactory::current().createAnimationTimeline();

AnimationPlayerForTesting player;

layerTreeView()->attachCompositorAnimationTimeline(compositorTimeline->animationTimeline());