Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorFactory.h

Issue 1663963004: Blink Compositor Animation: Use PassOwnPtr in CompositorFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@curves
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/CompositorFactory.h
diff --git a/third_party/WebKit/Source/platform/graphics/CompositorFactory.h b/third_party/WebKit/Source/platform/graphics/CompositorFactory.h
index 143a9918bcd270da0d0e2f6724a4871645b1b2bb..ac29c6e724940be3b7c170e994fcdbb87c3e5fc5 100644
--- a/third_party/WebKit/Source/platform/graphics/CompositorFactory.h
+++ b/third_party/WebKit/Source/platform/graphics/CompositorFactory.h
@@ -31,28 +31,28 @@ public:
// Animation ----------------------------------------------------
- virtual CompositorFilterAnimationCurve* createFilterAnimationCurve() { return nullptr; }
+ virtual PassOwnPtr<CompositorFilterAnimationCurve> createFilterAnimationCurve();
- virtual CompositorFloatAnimationCurve* createFloatAnimationCurve() { return nullptr; }
+ virtual PassOwnPtr<CompositorFloatAnimationCurve> createFloatAnimationCurve();
- virtual CompositorScrollOffsetAnimationCurve* createScrollOffsetAnimationCurve(
+ virtual PassOwnPtr<CompositorScrollOffsetAnimationCurve> createScrollOffsetAnimationCurve(
FloatPoint targetValue,
CompositorAnimationCurve::TimingFunctionType,
- CompositorScrollOffsetAnimationCurve::ScrollDurationBehavior) { return nullptr; }
+ CompositorScrollOffsetAnimationCurve::ScrollDurationBehavior);
- virtual CompositorTransformAnimationCurve* createTransformAnimationCurve() { return nullptr; }
+ virtual PassOwnPtr<CompositorTransformAnimationCurve> createTransformAnimationCurve();
- virtual CompositorTransformOperations* createTransformOperations() { return nullptr; }
+ virtual PassOwnPtr<CompositorTransformOperations> createTransformOperations();
- virtual CompositorFilterOperations* createFilterOperations() { return nullptr; }
+ virtual PassOwnPtr<CompositorFilterOperations> createFilterOperations();
- virtual CompositorAnimation* createAnimation(const CompositorAnimationCurve&, CompositorAnimation::TargetProperty, int groupId = 0, int animationId = 0) { return nullptr; }
+ virtual PassOwnPtr<CompositorAnimation> createAnimation(const CompositorAnimationCurve&, CompositorAnimation::TargetProperty, int groupId = 0, int animationId = 0);
- virtual CompositorAnimationPlayer* createAnimationPlayer() { return nullptr; }
+ virtual PassOwnPtr<CompositorAnimationPlayer> createAnimationPlayer();
- virtual CompositorAnimationTimeline* createAnimationTimeline() { return nullptr; }
+ virtual PassOwnPtr<CompositorAnimationTimeline> createAnimationTimeline();
- virtual ~CompositorFactory() {}
+ virtual ~CompositorFactory();
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698