Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1663893002: Precompilation: Make missing entry points an error. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: Make missing entry points an error. Narrow lookup of classes and top-level fields and functions to a library's local namespace. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/dbc538412e40950aba7a1f33ce929032b64b09ae

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M runtime/bin/main.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 2 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 10 months ago (2016-02-04 21:43:30 UTC) #2
Florian Schneider
lgtm https://chromiumcodereview.appspot.com/1663893002/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://chromiumcodereview.appspot.com/1663893002/diff/1/runtime/vm/precompiler.cc#newcode346 runtime/vm/precompiler.cc:346: String& msg = String::Handle(Z, String::NewFormatted( Uneven indentation?
4 years, 10 months ago (2016-02-04 21:51:48 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1663893002/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://chromiumcodereview.appspot.com/1663893002/diff/1/runtime/vm/precompiler.cc#newcode346 runtime/vm/precompiler.cc:346: String& msg = String::Handle(Z, String::NewFormatted( On 2016/02/04 21:51:48, Florian ...
4 years, 10 months ago (2016-02-04 22:25:57 UTC) #4
rmacnak
4 years, 10 months ago (2016-02-04 22:27:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
dbc538412e40950aba7a1f33ce929032b64b09ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698