Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1663853003: [Merge M48] "[Merge M49] Add SameVersionStartupCounts suffix to startup HardFault and Temperature h… (Closed)

Created:
4 years, 10 months ago by gab
Modified:
4 years, 10 months ago
Reviewers:
fdoray
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_m48_b2_startupVcount
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Merge M48] "[Merge M49] Add SameVersionStartupCounts suffix to startup HardFault and Temperature histograms." Also: - Move RecordTimeSinceLastStartup() and RecordStartupCount() as implementation details of RecordBrowserMainMessageLoopStart(). - Deprecate "Startup.BrowserMessageLoopStartHardFaultCount.FirstRun" histogram (obsolete and also replaced by the more generic "Startup.BrowserMessageLoopStartHardFaultCount.1") - Fix "Startup.BrowserMessageLoopStartHardFaultCount" to use 1 instead of 0 as minimum since 0 is implicit in UMA. - Fix "Startup.Temperature" to use STARTUP_TEMPERATURE_MAX instead of STARTUP_TEMPERATURE_COUNT as the |max_boundary| as this is what the UMA_HISTOGRAM_ENUMERATION macro expects FWICT. BUG=580211 Review URL: https://codereview.chromium.org/1637493002 Cr-Commit-Position: refs/heads/master@{#371630} (cherry picked from commit 45a4b5a72591338c60bd57ccf58f009e07e497b0) R=fdoray@chromium.org TBR=fdoray@chromium.org, fdoray@chromium.org Review URL: https://codereview.chromium.org/1656083002 . Cr-Commit-Position: refs/branch-heads/2623@{#239} Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907} (cherry picked from commit b977d3afe199294ec005b6f2b62dc25e10b30584) Conflicts: components/startup_metric_utils/browser/startup_metric_utils.cc Committed: https://chromium.googlesource.com/chromium/src/+/f99ee8ebbbce8e7cade10c55d78923329fb5cfb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -94 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/html_viewer/stats_collection_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.h View 2 chunks +8 lines, -15 lines 0 comments Download
M components/startup_metric_utils/browser/startup_metric_utils.cc View 7 chunks +124 lines, -73 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (3 generated)
gab
Planned merges to M48 -- @fdoray PTAL.
4 years, 10 months ago (2016-02-03 20:34:15 UTC) #2
fdoray
lgtm
4 years, 10 months ago (2016-02-03 20:49:08 UTC) #3
gab
4 years, 10 months ago (2016-02-04 02:06:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
f99ee8ebbbce8e7cade10c55d78923329fb5cfb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698