Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: third_party/WebKit/Source/platform/heap/TraceTraits.h

Issue 1663823002: If marking system stack is unknown, be more forgiving about stack depths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reorder logic Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/TraceTraits.h
diff --git a/third_party/WebKit/Source/platform/heap/TraceTraits.h b/third_party/WebKit/Source/platform/heap/TraceTraits.h
index 75ecd1690be4b4bdb18c9b6785cbee3278e729bd..561835589a84ce394cf1a56ef26578b2ffd04ed8 100644
--- a/third_party/WebKit/Source/platform/heap/TraceTraits.h
+++ b/third_party/WebKit/Source/platform/heap/TraceTraits.h
@@ -57,12 +57,7 @@ public:
// but test and appropriately handle them should they occur
// in release builds.
//
- // ASan adds extra stack usage, so disable the assert when it is
- // enabled so as to avoid testing against a much lower & too low,
- // stack depth threshold.
-#if !defined(ADDRESS_SANITIZER)
- ASSERT(!StackFrameDepth::isEnabled() || StackFrameDepth::isSafeToRecurse());
-#endif
+ ASSERT(StackFrameDepth::isAcceptableStackUse());
if (LIKELY(StackFrameDepth::isSafeToRecurse())) {
if (visitor->ensureMarked(t)) {
TraceTrait<T>::trace(visitor, const_cast<T*>(t));
« no previous file with comments | « third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698