If marking system stack is unknown, be more forgiving about stack depths.

If marking system stack is unknown, be more forgiving about stack depths.

In case we're unable to determine the stack size available for the GC
marking pass, a very conservative fallback size is used -- that size
being used to decide if the marking pass should switch to using lazy
marking instead.

If the fallback size is in effect, have the debug assert intended to catch
out unintentionally deep trace chains be more forgiving.

R=
BUG=581913
Committed: https://crrev.com/351d202395ed1754235b546447a5cc5c1ec2a8fa
Cr-Commit-Position: refs/heads/master@{#373514}

[sof, 2016-02-03 15:48:08]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-02-03 15:48:08]

please take a look.

an unusual assert this one, not sure we're gaining too much by having it.

[haraken, 2016-02-04 01:31:36]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-02-04 01:31:36]

LGTM

https://codereview.chromium.org/1663823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/StackFrameDepth.h (right):

https://codereview.chromium.org/1663823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/StackFrameDepth.h:53: return
!s_isEnabled || isSafeToRecurse() || (s_isUsingFallbackStackSize &&
(s_stackFrameLimit - currentStackFrame()) < 3 * kSafeStackFrameSize);

Nit: Slightly clearer:

if (s_isUsingFallbackStackSize)
  return ...;
return ...;

[sof, 2016-02-04 09:54:32]

https://codereview.chromium.org/1663823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/StackFrameDepth.h (right):

https://codereview.chromium.org/1663823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/StackFrameDepth.h:53: return
!s_isEnabled || isSafeToRecurse() || (s_isUsingFallbackStackSize &&
(s_stackFrameLimit - currentStackFrame()) < 3 * kSafeStackFrameSize);
On 2016/02/04 01:31:36, haraken wrote:
> 
> Nit: Slightly clearer:
> 
> if (s_isUsingFallbackStackSize)
>   return ...;
> return ...;

Done.

[sof, 2016-02-04 09:54:38]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2016-02-04 09:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1663823002/#ps40001
(title: "reorder logic")

[commit-bot: I haz the power, 2016-02-04 09:54:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663823002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663823002/40001

[commit-bot: I haz the power, 2016-02-04 12:28:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-04 12:30:01]

Description was changed from

==========
If marking system stack is unknown, be more forgiving about stack depths.

In case we're unable to determine the stack size available for the GC
marking pass, a very conservative fallback size is used -- that size
being used to decide if the marking pass should switch to using lazy
marking instead.

If the fallback size is in effect, have the debug assert intended to catch
out unintentionally deep trace chains be more forgiving.

R=
BUG=581913
==========

to

==========
If marking system stack is unknown, be more forgiving about stack depths.

In case we're unable to determine the stack size available for the GC
marking pass, a very conservative fallback size is used -- that size
being used to decide if the marking pass should switch to using lazy
marking instead.

If the fallback size is in effect, have the debug assert intended to catch
out unintentionally deep trace chains be more forgiving.

R=
BUG=581913

Committed: https://crrev.com/351d202395ed1754235b546447a5cc5c1ec2a8fa
Cr-Commit-Position: refs/heads/master@{#373514}
==========

[commit-bot: I haz the power, 2016-02-04 12:30:01]

Patchset 3 (id:??) landed as
https://crrev.com/351d202395ed1754235b546447a5cc5c1ec2a8fa
Cr-Commit-Position: refs/heads/master@{#373514}