|
|
Chromium Code Reviews|
Created:
4 years, 10 months ago by Geoff Lang Modified:
4 years, 10 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupress failures in the gl-get-calls WebGL2 confromance test.
Since the update to the chromium recipe, this test has been failing on the
ANGLE trybots, it may be because they're now running tests on windows
server 2008.
TBR=kbr@chromium.org,zmo@chromium.org
NOTRY=true
BUG=483282
Committed: https://crrev.com/4b0add7180c7d71804ff7d74e86fb48a87da1286
Cr-Commit-Position: refs/heads/master@{#373258}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 20 (9 generated)
Description was changed from ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 ========== to ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org BUG=483282 ==========
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663803002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663803002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
lgtm
Description was changed from ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org BUG=483282 ========== to ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 ==========
Setting as NOTRY, failures are unrelated.
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663803002/20001
Message was sent while issue was closed.
Description was changed from ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 ========== to ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 ========== to ========== Supress failures in the gl-get-calls WebGL2 confromance test. Since the update to the chromium recipe, this test has been failing on the ANGLE trybots, it may be because they're now running tests on windows server 2008. TBR=kbr@chromium.org,zmo@chromium.org NOTRY=true BUG=483282 Committed: https://crrev.com/4b0add7180c7d71804ff7d74e86fb48a87da1286 Cr-Commit-Position: refs/heads/master@{#373258} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4b0add7180c7d71804ff7d74e86fb48a87da1286 Cr-Commit-Position: refs/heads/master@{#373258}
Message was sent while issue was closed.
It looks to me like this test only just started failing today. On the Win7 Debug (NVIDIA) bot, here's a passing build: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVID... and the first failing build: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVID... There's definitely an ANGLE change in there, comparing parent_got_angle_revision between the two builds.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1661653005/ by geofflang@chromium.org. The reason for reverting is: Failure was ANGLE related, reverted ANGLE patch.. |
