Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 16638013: Adding annotations for native types of type Object or dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/dartmetadata.py
diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py
index e54caf0e1639cfc56504f3750000f74d95d0e98f..1429933ba38d17b83e1e5237658c63537b93027e 100644
--- a/tools/dom/scripts/dartmetadata.py
+++ b/tools/dom/scripts/dartmetadata.py
@@ -56,6 +56,10 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('String|CanvasGradient|CanvasPattern')",
],
+ 'CustomEvent.detail': [
+ "@Creates('Null')",
+ ],
+
# Normally DOMWindow is nevernull, but starting from a <template> element in
# JavaScript, this will be null:
# template.content.ownerDocument.defaultView
@@ -75,6 +79,10 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Creates('SqlDatabase')",
],
+ 'DOMWindow.showModalDialog': [
+ "@Creates('Null')",
+ ],
+
# To be in callback with the browser-created Event, we had to have called
# addEventListener on the target, so we avoid
'Event.currentTarget': [
@@ -88,18 +96,19 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@Returns('EventTarget|=Object')",
],
- 'MouseEvent.relatedTarget': [
- "@Creates('Node')",
- "@Returns('EventTarget|=Object')",
+ 'File.lastModifiedDate': [
+ "@Creates('Null')", # JS date object.
],
- # Touch targets are Elements in a Document, or the Document.
- 'Touch.target': [
- "@Creates('Element|Document')",
- "@Returns('Element|Document')",
+ 'FileReader.result': ["@Creates('String|ByteBuffer|Null')"],
+
+ 'FocusEvent.relatedTarget': [
+ "@Creates('Null')",
],
- 'FileReader.result': ["@Creates('String|ByteBuffer|Null')"],
+ 'HTMLInputElement.valueAsDate': [
+ "@Creates('Null')", # JS date object.
+ ],
# Rather than have the result of an IDBRequest as a union over all possible
# results, we mark the result as instantiating any classes, and mark
@@ -138,26 +147,82 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
"@_annotation_Returns_IDBKey",
],
- '+IDBRequest': [
+ 'IDBCursor.primaryKey': [
+ "@_annotation_Creates_IDBKey",
+ "@_annotation_Returns_IDBKey",
+ ],
+
+ 'IDBCursor.source': [
+ "@Creates('Null')",
+ "@Returns('ObjectStore|Index|Null')",
+ ],
+
+ 'IDBDatabase.version': [
+ "@Creates('int|String|Null')",
+ "@Returns('int|String|Null')",
+ ],
+
+ 'IDBIndex.keyPath': [
+ "@annotation_Creates_SerializedScriptValue",
+ ],
+
+ 'IDBKeyRange.lower': [
+ "@annotation_Creates_SerializedScriptValue",
+ ],
+
+ 'IDBKeyRange.upper': [
+ "@annotation_Creates_SerializedScriptValue",
+ ],
+
+ 'IDBObjectStore.keyPath': [
+ "@annotation_Creates_SerializedScriptValue",
+ ],
+
+ '+IDBOpenDBRequest': [
"@Returns('Request')",
"@Creates('Request')",
],
- '+IDBOpenDBRequest': [
+ '+IDBRequest': [
"@Returns('Request')",
"@Creates('Request')",
],
+ 'IDBVersionChangeEvent.newVersion': [
+ "@Creates('int|String|Null')",
+ "@Returns('int|String|Null')",
+ ],
+
+ 'IDBVersionChangeEvent.oldVersion': [
+ "@Creates('int|String|Null')",
+ "@Returns('int|String|Null')",
+ ],
+
'MessageEvent.ports': ["@Creates('=List')"],
'MessageEvent.data': [
"@annotation_Creates_SerializedScriptValue",
"@annotation_Returns_SerializedScriptValue",
],
+
+ 'Metadata.modificationTime': [
+ "@Creates('Null')", # JS date object.
+ ],
+
+ 'MouseEvent.relatedTarget': [
+ "@Creates('Node')",
+ "@Returns('EventTarget|=Object')",
+ ],
+
'PopStateEvent.state': [
"@annotation_Creates_SerializedScriptValue",
"@annotation_Returns_SerializedScriptValue",
],
+
+ 'RTCStatsReport.timestamp': [
+ "@Creates('Null')", # JS date object.
+ ],
+
'SerializedScriptValue': [
"@annotation_Creates_SerializedScriptValue",
"@annotation_Returns_SerializedScriptValue",
@@ -165,6 +230,56 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {
'SQLResultSetRowList.item': ["@Creates('=Object')"],
+ # Touch targets are Elements in a Document, or the Document.
+ 'Touch.target': [
+ "@Creates('Element|Document')",
+ "@Returns('Element|Document')",
+ ],
+
+ 'TrackEvent.track': [
+ "@Creates('Null')",
+ ],
+
+ 'WebGLRenderingContext.getBufferParameter': [
+ "@Creates('int|Null')",
+ "@Returns('int|Null')",
+ ],
+
+ 'WebGLRenderingContext.getFramebufferAttachmentParameter': [
+ "@Creates('int|RenderBuffer|Texture|Null')",
+ "@Returns('int|RenderBuffer|Texture|Null')",
+ ],
+
+ 'WebGLRenderingContext.getProgramParameter': [
+ "@Creates('int|bool|Null')",
+ "@Returns('int|bool|Null')",
+ ],
+
+ 'WebGLRenderingContext.getRenderbufferParameter': [
+ "@Creates('int|Null')",
+ "@Returns('int|Null')",
+ ],
+
+ 'WebGLRenderingContext.getShaderParameter': [
+ "@Creates('int|Null')",
+ "@Returns('int|Null')",
+ ],
+
+ 'WebGLRenderingContext.getTexParameter': [
+ "@Creates('int|Null')",
+ "@Returns('int|Null')",
+ ],
+
+ 'WebGLRenderingContext.getUniform': [
+ "@Creates('Null|num|String|bool|=List|Float32List|Int32List|Uint32List')",
+ "@Returns('Null|num|String|bool|=List|Float32List|Int32List|Uint32List')",
+ ],
+
+ 'WebGLRenderingContext.getVertexAttrib': [
+ "@Creates('Null|num|bool|Float32List|Buffer')",
+ "@Returns('Null|num|bool|Float32List|Buffer')",
+ ],
+
'WebGLRenderingContext.getParameter': [
# Taken from http://www.khronos.org/registry/webgl/specs/latest/
# Section 5.14.3 Setting and getting state

Powered by Google App Engine
This is Rietveld 408576698