sdk/lib/web_audio/dart2js/web_audio_dart2js.dart - Issue 16638013: Adding annotations for native types of type Object or dynamic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

Issue 16638013: Adding annotations for native types of type Object or dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart ('k') | sdk/lib/web_gl/dart2js/web_gl_dart2js.dart » ('j') | tools/dom/templates/html/impl/impl_AudioContext.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

diff --git a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

index 5269d55efc15197bdde84e48546853f7fdd4bbbe..bbae87ac00268f4cab02d0ffa95fb9605854196f 100644

--- a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

+++ b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

@@ -340,7 +340,7 @@ class AudioContext extends EventTarget native "AudioContext" {

ScriptProcessorNode createScriptProcessor(int bufferSize,

[int numberOfInputChannels, int numberOfOutputChannels]) {

- var function = JS('dynamic', '#.createScriptProcessor || '

+ var function = JS('Function', '#.createScriptProcessor || '

sra1 2013/06/11 18:54:15 This type is claiming that a JS function is a Dart

blois 2013/06/11 19:07:46 Done.

'#.createJavaScriptNode', this, this);

if (numberOfOutputChannels != null) {

return JS('ScriptProcessorNode', '#.call(#, #, #, #)', function, this,