Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 16638011: Disable --harmony -> --harmony-generators implication (Closed)

Created:
7 years, 6 months ago by wingo
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev, Michael Starzinger, rossberg
Visibility:
Public.

Description

Disable --harmony -> --harmony-generators implication A GC-related bug has started showing up after r15060 that unfortunately I haven't been able to reproduce. Disable generators by default for the Canary push. R=danno@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15065

Patch Set 1 #

Patch Set 2 : Fix flag-definitions style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/iteration-semantics.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
7 years, 6 months ago (2013-06-11 14:39:21 UTC) #1
wingo
Disabling generators as requested. Sure would be nice to be able to reproduce this one, ...
7 years, 6 months ago (2013-06-11 14:40:50 UTC) #2
danno
lgtm
7 years, 6 months ago (2013-06-11 14:42:36 UTC) #3
wingo
7 years, 6 months ago (2013-06-11 14:45:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698