Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1663773003: Remove redundant/unnecessary variables and checks in ParseForStatement (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove redundant/unnecessary variables and checks in ParseForStatement Committed: https://crrev.com/ea8f7827999d9ce9e3512e54b8a9fe3207ccada0 Cr-Commit-Position: refs/heads/master@{#33748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -43 lines) Patch
M src/ast/ast.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/messages.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 6 chunks +11 lines, -22 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
adamk
4 years, 10 months ago (2016-02-03 22:30:58 UTC) #4
adamk
4 years, 10 months ago (2016-02-03 22:30:58 UTC) #5
rossberg
lgtm
4 years, 10 months ago (2016-02-04 13:26:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663773003/1
4 years, 10 months ago (2016-02-04 18:37:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 18:39:10 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 18:39:30 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ea8f7827999d9ce9e3512e54b8a9fe3207ccada0
Cr-Commit-Position: refs/heads/master@{#33748}

Powered by Google App Engine
This is Rietveld 408576698