Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 1663753004: Add accidentally deleted 'if /x64' line back (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add accidentally deleted 'if /x64' line back BUG=440500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298580

Patch Set 1 #

Patch Set 2 : Add back missing line to SetEnv.cmd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M win_toolchain/package_from_installed.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Embarrassing. I made a 'trivial' change two weeks ago, apparently after finishing testing and packaging, ...
4 years, 10 months ago (2016-02-03 23:23:25 UTC) #2
scottmg
Sorry I missed it. lgtm
4 years, 10 months ago (2016-02-03 23:28:29 UTC) #3
brucedawson
On 2016/02/03 23:28:29, scottmg wrote: > Sorry I missed it. lgtm I think it may ...
4 years, 10 months ago (2016-02-03 23:31:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663753004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663753004/20001
4 years, 10 months ago (2016-02-04 00:34:36 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 00:36:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298580

Powered by Google App Engine
This is Rietveld 408576698