Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1663753003: Additional errors for SVG transform list parsing (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Additional errors for SVG transform list parsing This adds specific error messages for missing/incorrect transform functions and missing '(' at the start of a transform function argument list. BUG=231612 Committed: https://crrev.com/72efc7b8f0c05eadd4b083394161db0997cd050a Cr-Commit-Position: refs/heads/master@{#373491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGParsingError.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 10 months ago (2016-02-03 21:13:47 UTC) #2
pdr.
On 2016/02/03 at 21:13:47, fs wrote: > LGTM
4 years, 10 months ago (2016-02-03 21:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663753003/1
4 years, 10 months ago (2016-02-04 09:03:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 09:38:19 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:40:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72efc7b8f0c05eadd4b083394161db0997cd050a
Cr-Commit-Position: refs/heads/master@{#373491}

Powered by Google App Engine
This is Rietveld 408576698