Source/bindings/core/dart/V8Converter.cpp - Issue 1663753002: Apply all blink changes between @202695 and tip of trunk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/dart/V8Converter.cpp

Issue 1663753002: Apply all blink changes between @202695 and tip of trunk (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/dart/V8Converter.cpp

diff --git a/Source/bindings/core/dart/V8Converter.cpp b/Source/bindings/core/dart/V8Converter.cpp

index 31d0874f504ffab8fd0771c1c3dc0a5935f120c4..2200818f5c2df1a4bcfa81b3279b17e9d4bfa88c 100644

--- a/Source/bindings/core/dart/V8Converter.cpp

+++ b/Source/bindings/core/dart/V8Converter.cpp

@@ -142,7 +142,7 @@ v8::Handle<v8::Value> V8Converter::toV8IfBrowserNative(DartDOMData* domData, Dar

return arrayBufferToV8(data, exception);

}

if (Dart_IsTypedData(value))

- return arrayBufferToV8(value, exception);

+ return arrayBufferViewToV8(value, exception);

// TODO(terry): Using JS Interop only arrays are converted.

if (DartDOMWrapper::subtypeOf(value, DartBlob::dartClassId))