Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1663743003: MD - Update incognito frame colors. (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD - Update incognito frame colors. For now, just update assets. Eventually, we should draw colors instead of tiling images. BUG=583797 TBR=oshima@chromium.org Committed: https://crrev.com/41622adb9656f151f9c8e69c9c40f84b4d04ef04 Cr-Commit-Position: refs/heads/master@{#373625}

Patch Set 1 #

Patch Set 2 : update more assets #

Messages

Total messages: 19 (10 generated)
Evan Stade
we also need to update the inactive png, but I'm waiting for sgabriel to tell ...
4 years, 10 months ago (2016-02-04 01:42:41 UTC) #2
Peter Kasting
LGTM
4 years, 10 months ago (2016-02-04 01:45:32 UTC) #4
tdanderson
LGTM also
4 years, 10 months ago (2016-02-04 15:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663743003/20001
4 years, 10 months ago (2016-02-04 19:19:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/142704)
4 years, 10 months ago (2016-02-04 19:29:28 UTC) #10
Evan Stade
+oshima tbr for assets
4 years, 10 months ago (2016-02-04 21:21:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663743003/20001
4 years, 10 months ago (2016-02-04 21:23:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-04 21:36:36 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 21:37:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41622adb9656f151f9c8e69c9c40f84b4d04ef04
Cr-Commit-Position: refs/heads/master@{#373625}

Powered by Google App Engine
This is Rietveld 408576698