Use persistent map of privet tokens for PrivetURLFetcher

chrome/browser/local_discovery/privet_http_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/local_discovery/privet_http_impl.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/url_request/test_url_fetcher_factory.h"
@@ skipping 184 matching lines @@
   // Uploaded chunks can be retrieved with the |upload_chunks()| getter.
   MOCK_METHOD1(OnChunkUpload, void(int fetcher_id));
 
   // Callback issued correspondingly to the destructor.
   MOCK_METHOD1(OnRequestEnd, void(int fetcher_id));
 };
 
 class PrivetHTTPTest : public ::testing::Test {
  public:
   PrivetHTTPTest() {
+    PrivetURLFetcher::ResetTokenMapForTests();
+
     request_context_= new net::TestURLRequestContextGetter(
         base::MessageLoopProxy::current());
     privet_client_.reset(new PrivetHTTPClientImpl(
         "sampleDevice._privet._tcp.local",
         net::HostPortPair("10.0.0.8", 6006),
         request_context_.get()));
     fetcher_factory_.SetDelegateForTests(&fetcher_delegate_);
   }
 
   virtual ~PrivetHTTPTest() {
@@ skipping 220 matching lines @@
   EXPECT_EQ(GURL("http://10.0.0.8:6006/privet/info"),
             fetcher->GetOriginalURL());
 
   fetcher->SetResponseString(kSampleInfoResponse);
   fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
                                             net::OK));
   fetcher->set_response_code(200);
 
   EXPECT_CALL(info_callback_, OnPrivetJSONDoneInternal());
   fetcher->delegate()->OnURLFetchComplete(fetcher);
-
-  std::string name;
-
-  privet_client_->GetCachedInfo()->GetString("name", &name);
-  EXPECT_EQ("Common printer", name);
-};
-
-TEST_F(PrivetInfoTest, InfoSaveToken) {
-  info_operation_->Start();
-
-  net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);
-  ASSERT_TRUE(fetcher != NULL);
-  fetcher->SetResponseString(kSampleInfoResponse);
-  fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
-                                            net::OK));
-  fetcher->set_response_code(200);
-
-  EXPECT_CALL(info_callback_, OnPrivetJSONDoneInternal());
-  fetcher->delegate()->OnURLFetchComplete(fetcher);
-
-  info_operation_ =
-      privet_client_->CreateInfoOperation(info_callback_.callback());
-  info_operation_->Start();
-
-  fetcher = fetcher_factory_.GetFetcherByID(0);
-  ASSERT_TRUE(fetcher != NULL);
-  net::HttpRequestHeaders headers;
-  fetcher->GetExtraRequestHeaders(&headers);
-  std::string header_token;
-  ASSERT_TRUE(headers.GetHeader("X-Privet-Token", &header_token));
-  EXPECT_EQ("SampleTokenForTesting", header_token);
 };
 
 TEST_F(PrivetInfoTest, InfoFailureHTTP) {
   info_operation_->Start();
 
   net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);
   ASSERT_TRUE(fetcher != NULL);
   fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
                                             net::OK));
   fetcher->set_response_code(404);
 
   EXPECT_CALL(info_callback_, OnPrivetJSONDoneInternal());
   fetcher->delegate()->OnURLFetchComplete(fetcher);
-  EXPECT_EQ(NULL, privet_client_->GetCachedInfo());
 };
 
 class PrivetRegisterTest : public PrivetHTTPTest {
  public:
   PrivetRegisterTest() {
   }
   virtual ~PrivetRegisterTest() {
   }
 
   virtual void SetUp() OVERRIDE {
@@ skipping 21 matching lines @@
     return true;
   }
 
   scoped_ptr<PrivetJSONOperation> info_operation_;
   NiceMock<MockJSONCallback> info_callback_;
   scoped_ptr<PrivetRegisterOperation> register_operation_;
   StrictMock<MockRegisterDelegate> register_delegate_;
 };
 
 TEST_F(PrivetRegisterTest, RegisterSuccessSimple) {
-  // Start with info request first to populate XSRF token.
-  info_operation_->Start();
+  register_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  register_operation_->Start();
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=start&user=example%40google.com"),
       kSampleRegisterStartResponse));
 
   EXPECT_CALL(register_delegate_, OnPrivetRegisterClaimTokenInternal(
       "MySampleToken",
       GURL("https://domain.com/SoMeUrL")));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=getClaimToken&user=example%40google.com"),
       kSampleRegisterGetClaimTokenResponse));
 
   register_operation_->CompleteRegistration();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=complete&user=example%40google.com"),
       kSampleRegisterCompleteResponse));
 
   EXPECT_CALL(register_delegate_, OnPrivetRegisterDoneInternal(
       "MyDeviceID"));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseRegistered));
 }
 
-TEST_F(PrivetRegisterTest, RegisterNoInfoCall) {
-  register_operation_->Start();
-
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/info"),
-      kSampleInfoResponse));
-
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/register?"
-           "action=start&user=example%40google.com"),
-      kSampleRegisterStartResponse));
-}
-
 TEST_F(PrivetRegisterTest, RegisterXSRFFailure) {
   register_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=start&user=example%40google.com"),
@@ skipping 73 matching lines @@
                   "start",
                   PrivetRegisterOperation::FAILURE_TOKEN,
                   -1));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseBadJson));
 }
 
 TEST_F(PrivetRegisterTest, RegisterCancel) {
-  // Start with info request first to populate XSRF token.
-  info_operation_->Start();
+  register_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  register_operation_->Start();
-
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=start&user=example%40google.com"),
       kSampleRegisterStartResponse));
 
   register_operation_->Cancel();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/register?"
            "action=cancel&user=example%40google.com"),
@@ skipping 85 matching lines @@
       kSampleCapabilitiesResponse));
 };
 
 class PrivetLocalPrintTest : public PrivetHTTPTest {
  public:
   PrivetLocalPrintTest() {}
 
   virtual ~PrivetLocalPrintTest() {}
 
   virtual void SetUp() OVERRIDE {
+    PrivetURLFetcher::ResetTokenMapForTests();
+
     local_print_operation_ = privet_client_->CreateLocalPrintOperation(
         &local_print_delegate_);
 
     local_print_operation_->SetPWGRasterConverterForTesting(
         scoped_ptr<PWGRasterConverter>(new FakePWGRasterConverter));
   }
 
   scoped_refptr<base::RefCountedBytes> RefCountedBytesFromString(
       std::string str) {
     std::vector<unsigned char> str_vec;
@@ skipping 11 matching lines @@
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(RefCountedBytesFromString(
       "Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/capabilities"),
+                              kSampleCapabilitiesResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com&"
            "job_name=Sample+job+name"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithAnyMimetype) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponseWithAnyMimetype));
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/capabilities"),
+                              kSampleCapabilitiesResponseWithAnyMimetype));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com&"
            "job_name=Sample+job+name"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulPWGLocalPrint) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetData(
       RefCountedBytesFromString("path/to/"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponse));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponsePWGOnly));
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/capabilities"),
+                              kSampleCapabilitiesResponsePWGOnly));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndFilePath(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com"
            "&job_name=Sample+job+name"),
       base::FilePath(FILE_PATH_LITERAL("path/to/test.pdf")),
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, SuccessfulLocalPrintWithCreatejob) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/capabilities"),
+                              kSampleCapabilitiesResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
   EXPECT_CALL(local_print_delegate_, OnPrivetPrintingDoneInternal());
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com&"
            "job_name=Sample+job+name&job_id=1234"),
       "Sample print data",
       kSampleLocalPrintResponse));
 };
 
 TEST_F(PrivetLocalPrintTest, PDFPrintInvalidDocumentTypeRetry) {
   local_print_operation_->SetUsername("sample@gmail.com");
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
   local_print_operation_->SetData(
       RefCountedBytesFromString("sample/path/"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
-  EXPECT_TRUE(SuccessfulResponseToURL(
-      GURL("http://10.0.0.8:6006/privet/capabilities"),
-      kSampleCapabilitiesResponse));
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
+  EXPECT_TRUE(
+      SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/capabilities"),
+                              kSampleCapabilitiesResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
   // TODO(noamsml): Is encoding spaces as pluses standard?
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com&"
@@ skipping 16 matching lines @@
   local_print_operation_->SetJobname("Sample job name");
   local_print_operation_->SetTicket("Sample print ticket");
   local_print_operation_->SetData(
       RefCountedBytesFromString("Sample print data"));
   local_print_operation_->Start();
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/info"),
       kSampleInfoResponseWithCreatejob));
 
+  EXPECT_TRUE(SuccessfulResponseToURL(GURL("http://10.0.0.8:6006/privet/info"),
+                                      kSampleInfoResponse));
+
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/capabilities"),
       kSampleCapabilitiesResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       "Sample print ticket",
       kSampleCreatejobResponse));
 
   EXPECT_TRUE(SuccessfulResponseToURLAndData(
       GURL("http://10.0.0.8:6006/privet/printer/submitdoc?"
            "client_name=Chrome&user_name=sample%40gmail.com&"
            "job_name=Sample+job+name&job_id=1234"),
       "Sample print data",
       kSampleErrorResponsePrinterBusy));
 
   RunFor(base::TimeDelta::FromSeconds(3));
 
   EXPECT_TRUE(SuccessfulResponseToURL(
       GURL("http://10.0.0.8:6006/privet/printer/createjob"),
       kSampleCreatejobResponse));
 };
 
 
 }  // namespace
 
 }  // namespace local_discovery