Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 1663723002: [DevTools] Add sourceMap support for blackboxing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@call-set-blackboxed-ranges-on-script-parsed
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
index 9866520943997d4c9f1e5192271d6bb115af4a70..f79e64247f8841efda13d573cf0a82d607289391 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
@@ -118,7 +118,7 @@ WebInspector.CallStackSidebarPane.prototype = {
callFrameItem.element.addEventListener("contextmenu", this._callFrameContextMenu.bind(this, callFrameItem), true);
this.callFrames.push(callFrameItem);
- if (WebInspector.BlackboxSupport.isBlackboxed(callFrame.script.sourceURL, callFrame.script.isContentScript())) {
+ if (WebInspector.blackboxManager.isBlackboxedScript(callFrame.script)) {
callFrameItem.setHidden(true);
callFrameItem.setDimmed(true);
++this._hiddenCallFrames;
@@ -197,8 +197,10 @@ WebInspector.CallStackSidebarPane.prototype = {
*/
appendBlackboxURLContextMenuItems: function(contextMenu, url, isContentScript)
{
- var blackboxed = WebInspector.BlackboxSupport.isBlackboxed(url, isContentScript);
- var canBlackBox = WebInspector.BlackboxSupport.canBlackboxURL(url);
+ var blackboxed = WebInspector.blackboxManager.isBlackboxedContentScripts() && isContentScript;
dgozman 2016/02/09 23:44:51 Can we switch this to isUISourceCodeBlackboxed?
kozy 2016/02/10 01:19:42 Done.
+ if (!blackboxed)
+ blackboxed = WebInspector.blackboxManager.isBlackboxedURL(url);
+ var canBlackBox = WebInspector.blackboxManager.canBlackboxURL(url);
if (!blackboxed && !isContentScript && !canBlackBox)
return;
@@ -223,9 +225,9 @@ WebInspector.CallStackSidebarPane.prototype = {
if (isContentScript)
WebInspector.moduleSetting("skipContentScripts").set(true);
else
- WebInspector.BlackboxSupport.blackboxURL(url);
+ WebInspector.blackboxManager.blackboxURL(url);
} else {
- WebInspector.BlackboxSupport.unblackbox(url, isContentScript);
+ WebInspector.blackboxManager.unblackbox(url, isContentScript);
}
},

Powered by Google App Engine
This is Rietveld 408576698