[DevTools] Add sourceMap support for blackboxing

[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193, 341082
Committed: https://crrev.com/8598709b162ff0493a2eb36a72891bd2043d8e71
Cr-Commit-Position: refs/heads/master@{#375794}

[kozy, 2016-02-03 02:40:55]

ptal

[dgozman, 2016-02-03 18:24:11]

We decided to not load sourcemap for blackboxed script. Let's do it in this
patch.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-sourcemap.html
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-sourcemap.html:34:
"StepInto", "StepInto", "Print", // entered callback(i)
Can we have more extensive test? Examine async call stack for example? Or
pausing in setTimeout in blackboxed framework code which calls into |callback|?

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:15:
this._sourceMapForScriptId = new Map();
Ask CompilerScriptMapping instead of keeping a separate map.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:68: if
(currentBlackboxed !==
WebInspector.BlackboxSupport.isBlackboxedURL(mapping.sourceURL)) {
Ain't this slow? Should we cache instead of regexp'ing all the time?

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:190:
script.dispatchEventToListeners(WebInspector.Script.Events.SourceMapLoaded,
sourceMap);
Just make a direct call into BlackboxManager.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js (right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js:248: return
this._mappings;
indentation

[kozy, 2016-02-09 23:02:41]

Patchset #3 (id:40001) has been deleted

[kozy, 2016-02-09 23:10:09]

All done.
I'm going to add ignoring source map in next CL.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-sourcemap.html
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-sourcemap.html:34:
"StepInto", "StepInto", "Print", // entered callback(i)
On 2016/02/03 18:24:10, dgozman wrote:
> Can we have more extensive test? Examine async call stack for example? Or
> pausing in setTimeout in blackboxed framework code which calls into
|callback|?

This test is checked stepping behavior with blackboxing. We don't use
information about async stack traces while stepping now.
We can add another test after improving after async stepping.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:15:
this._sourceMapForScriptId = new Map();
On 2016/02/03 18:24:10, dgozman wrote:
> Ask CompilerScriptMapping instead of keeping a separate map.

Done.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:68: if
(currentBlackboxed !==
WebInspector.BlackboxSupport.isBlackboxedURL(mapping.sourceURL)) {
On 2016/02/03 18:24:10, dgozman wrote:
> Ain't this slow? Should we cache instead of regexp'ing all the time?

Done.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:190:
script.dispatchEventToListeners(WebInspector.Script.Events.SourceMapLoaded,
sourceMap);
On 2016/02/03 18:24:10, dgozman wrote:
> Just make a direct call into BlackboxManager.

Done.

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js (right):

https://codereview.chromium.org/1663723002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js:248: return
this._mappings;
On 2016/02/03 18:24:11, dgozman wrote:
> indentation

Done.

[dgozman, 2016-02-09 23:44:51]

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:15:
this._scripts = new Map();
Store blackbox ranges per script instead.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:15:
this._scripts = new Map();
Clean this up on GlobalObjectCleared.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:17:
this._isBlackboxedURLCache = new Map();
Let's clear on GlobalObjectCleared to avoid leaks.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:20:
WebInspector.BlackboxManager.ScriptState = {
Make this a enum and use in JSDocs.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:50:
isBlackboxedScript: function(script)
Remove this method, add one with rawLocation instead.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:76:
isBlackboxedContentScripts: function()
Replace with isUISourceCodeBlackboxed.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:225:
_patternChangeFinished: function()
...forTests

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:226: {
// This method is sniffed in tests.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:267:
return WebInspector.debuggerWorkspaceBinding.sourceMapForScript(script);
Pass it as a parameter in constructor.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js:28:
WebInspector.blackboxManager.isBlackboxedScript(script) :
Since script may be partially blackboxed, you have to pass line and column.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:209:
WebInspector.blackboxManager.isBlackboxedScript(script) :
Same as before.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:314: reject(error);
console.error(error)

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:315: fulfill(error);
fullfill();

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:200:
var blackboxed = WebInspector.blackboxManager.isBlackboxedContentScripts() &&
isContentScript;
Can we switch this to isUISourceCodeBlackboxed?

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:153:
if ((WebInspector.blackboxManager.isBlackboxedContentScripts() &&
isContentScript) || WebInspector.blackboxManager.isBlackboxedURL(url)) {
isUISourceCodeBlackboxed()

[kozy, 2016-02-10 01:19:42]

All done!

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:15:
this._scripts = new Map();
On 2016/02/09 23:44:50, dgozman wrote:
> Clean this up on GlobalObjectCleared.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:15:
this._scripts = new Map();
On 2016/02/09 23:44:50, dgozman wrote:
> Store blackbox ranges per script instead.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:17:
this._isBlackboxedURLCache = new Map();
On 2016/02/09 23:44:50, dgozman wrote:
> Let's clear on GlobalObjectCleared to avoid leaks.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:20:
WebInspector.BlackboxManager.ScriptState = {
On 2016/02/09 23:44:50, dgozman wrote:
> Make this a enum and use in JSDocs.
Removed.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:50:
isBlackboxedScript: function(script)
On 2016/02/09 23:44:50, dgozman wrote:
> Remove this method, add one with rawLocation instead.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:76:
isBlackboxedContentScripts: function()
On 2016/02/09 23:44:50, dgozman wrote:
> Replace with isUISourceCodeBlackboxed.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:225:
_patternChangeFinished: function()
On 2016/02/09 23:44:51, dgozman wrote:
> ...forTests

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:226: {
On 2016/02/09 23:44:50, dgozman wrote:
> // This method is sniffed in tests.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:267:
return WebInspector.debuggerWorkspaceBinding.sourceMapForScript(script);
On 2016/02/09 23:44:50, dgozman wrote:
> Pass it as a parameter in constructor.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js:28:
WebInspector.blackboxManager.isBlackboxedScript(script) :
On 2016/02/09 23:44:51, dgozman wrote:
> Since script may be partially blackboxed, you have to pass line and column.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:209:
WebInspector.blackboxManager.isBlackboxedScript(script) :
On 2016/02/09 23:44:51, dgozman wrote:
> Same as before.

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:314: reject(error);
On 2016/02/09 23:44:51, dgozman wrote:
> console.error(error)

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:315: fulfill(error);
On 2016/02/09 23:44:51, dgozman wrote:
> fullfill();

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:200:
var blackboxed = WebInspector.blackboxManager.isBlackboxedContentScripts() &&
isContentScript;
On 2016/02/09 23:44:51, dgozman wrote:
> Can we switch this to isUISourceCodeBlackboxed?

Done.

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/1663723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:153:
if ((WebInspector.blackboxManager.isBlackboxedContentScripts() &&
isContentScript) || WebInspector.blackboxManager.isBlackboxedURL(url)) {
On 2016/02/09 23:44:51, dgozman wrote:
> isUISourceCodeBlackboxed()

Done.

[kozy, 2016-02-11 02:17:58]

Patchset #4 (id:80001) has been deleted

[kozy, 2016-02-11 02:18:08]

Patchset #4 (id:100001) has been deleted

[kozy, 2016-02-11 20:28:59]

Patchset #4 (id:120001) has been deleted

[dgozman, 2016-02-17 01:34:44]

lgtm

https://codereview.chromium.org/1663723002/diff/140001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js
(right):

https://codereview.chromium.org/1663723002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/components/DebuggerPresentationUtils.js:29:
WebInspector.blackboxManager.isBlackboxedURL(callFrame.url);
I doubt there could be callFrame without debuggerModel or location. Let's
rephrase this:

if (!location ||
!WebInspector.blackboxManager.isBlackboxedRawLocation(location))
    return callFrame;

https://codereview.chromium.org/1663723002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/1663723002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:210:
WebInspector.blackboxManager.isBlackboxedURL(callFrame.url);
Similar to previous comment.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:21:
this._scripts = new Map();
this._scriptIdToPositions

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:58:
function comparator(a, b)
JSDoc plesae.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:119: if
(mappings[0].lineNumber !== 0 || mappings[0].columnNumber !== 0) {
Let's add a comment.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:135: if
(!isChanged)
hasChanged

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:138: if
(isBlackboxed)
Can we get rid of this flag?

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:144: *
@param {!WebInspector.SourceMap.Entry} b
@return {number}

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:225:
promises.push(this._addScript(script).then(loadSourceMap.bind(this, script)));
this._addScript(script)
    .then(() => this._sourceMapForScript(script))
    .then((sourceMap) => this.sourceMapLoaded(script, sourceMap));

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:289:
return this._debuggerWorkspaceBinding.sourceMapForScript(script);
Inline it!

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:294: * @return
{!Promise<?Array<!DebuggerAgent.ScriptPosition>>}
!Promise<boolean>

[kozy, 2016-02-17 03:40:43]

all done

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
(right):

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:21:
this._scripts = new Map();
On 2016/02/17 01:34:44, dgozman wrote:
> this._scriptIdToPositions

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:58:
function comparator(a, b)
On 2016/02/17 01:34:44, dgozman wrote:
> JSDoc plesae.

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:119: if
(mappings[0].lineNumber !== 0 || mappings[0].columnNumber !== 0) {
On 2016/02/17 01:34:44, dgozman wrote:
> Let's add a comment.

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:135: if
(!isChanged)
On 2016/02/17 01:34:44, dgozman wrote:
> hasChanged

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:138: if
(isBlackboxed)
On 2016/02/17 01:34:44, dgozman wrote:
> Can we get rid of this flag?

We can't rid of this because when positions.length === 1, positions[0] can be
our fake blackboxed positions for begin of mapped script. Change it to
hasFakeBlackboxed.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:144: *
@param {!WebInspector.SourceMap.Entry} b
On 2016/02/17 01:34:44, dgozman wrote:
> @return {number}

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:225:
promises.push(this._addScript(script).then(loadSourceMap.bind(this, script)));
On 2016/02/17 01:34:44, dgozman wrote:
> this._addScript(script)
>     .then(() => this._sourceMapForScript(script))
>     .then((sourceMap) => this.sourceMapLoaded(script, sourceMap));

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:289:
return this._debuggerWorkspaceBinding.sourceMapForScript(script);
On 2016/02/17 01:34:44, dgozman wrote:
> Inline it!

Done.

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/1663723002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:294: * @return
{!Promise<?Array<!DebuggerAgent.ScriptPosition>>}
On 2016/02/17 01:34:44, dgozman wrote:
> !Promise<boolean>

Done.

[kozy, 2016-02-17 03:40:47]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-02-17 03:40:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1663723002/#ps200001
(title: " ")

[kozy, 2016-02-17 03:42:19]

Description was changed from

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193
==========

to

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193,341082
==========

[commit-bot: I haz the power, 2016-02-17 03:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663723002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663723002/200001

[commit-bot: I haz the power, 2016-02-17 04:50:31]

Description was changed from

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193,341082
==========

to

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193,341082
==========

[commit-bot: I haz the power, 2016-02-17 04:50:31]

Committed patchset #7 (id:200001)

[commit-bot: I haz the power, 2016-02-17 04:51:29]

Description was changed from

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193,341082
==========

to

==========
[DevTools] Add sourceMap support for blackboxing

Use script's source map for calculating blackbox ranges.

R=dgozman@chromium.org
BUG=583193,341082

Committed: https://crrev.com/8598709b162ff0493a2eb36a72891bd2043d8e71
Cr-Commit-Position: refs/heads/master@{#375794}
==========

[commit-bot: I haz the power, 2016-02-17 04:51:30]

Patchset 7 (id:??) landed as
https://crrev.com/8598709b162ff0493a2eb36a72891bd2043d8e71
Cr-Commit-Position: refs/heads/master@{#375794}