Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1663703003: use std::unordered_map and std::unordered_set in QUIC code instead of (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@113259990
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use std::unordered_map and std::unordered_set in QUIC code instead of hash_map and hash_set. Merge internal change: 113278032 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -30 lines) Patch
M net/quic/quic_chromium_client_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_frame_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_multipath_received_packet_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_multipath_transmissions_map.h View 2 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_multipath_transmissions_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_multipath_transmissions_map_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.h View 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/spdy_utils_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 4 chunks +9 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-03 06:30:18 UTC) #1
Ryan Hamilton
LGTM, but one question https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_transmissions_map_test.cc File net/quic/quic_multipath_transmissions_map_test.cc (left): https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_transmissions_map_test.cc#oldcode8 net/quic/quic_multipath_transmissions_map_test.cc:8: namespace net_quic { Hm. If ...
4 years, 10 months ago (2016-02-03 14:39:45 UTC) #2
ramant (doing other things)
https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_transmissions_map_test.cc File net/quic/quic_multipath_transmissions_map_test.cc (left): https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_transmissions_map_test.cc#oldcode8 net/quic/quic_multipath_transmissions_map_test.cc:8: namespace net_quic { On 2016/02/03 14:39:45, Ryan Hamilton wrote: ...
4 years, 10 months ago (2016-02-03 19:37:53 UTC) #3
Ryan Hamilton
4 years, 10 months ago (2016-02-04 00:14:28 UTC) #4
On 2016/02/03 19:37:53, ramant wrote:
>
https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_tra...
> File net/quic/quic_multipath_transmissions_map_test.cc (left):
> 
>
https://codereview.chromium.org/1663703003/diff/1/net/quic/quic_multipath_tra...
> net/quic/quic_multipath_transmissions_map_test.cc:8: namespace net_quic {
> On 2016/02/03 14:39:45, Ryan Hamilton wrote:
> > Hm. If this was in namespace net_quic, I don't think it would have compiled.
> Can
> > you confirm that this is in net.gypi? (and any other net_quic files)
> 
> It is in the net.gyp. I had a compile issues when I didn't mention "net::".
Then
> I started looking why I had to specify "net::" and found the namespace issue.
> 
> This file was compiling before because quic_multipath_transmissions_map.h was
in
> net_quic and they had net::. Will remove net:: from these files.

gotcha. lgtm

Powered by Google App Engine
This is Rietveld 408576698