Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1663673005: Perf sheriff doc: Minor fixes. (Closed)

Created:
4 years, 10 months ago by mustaq
Modified:
4 years, 10 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perf sheriff doc: Minor fixes. BUG= Committed: https://crrev.com/5527f553b5f37b3bf74bfb16c874bc0aa2c86cff Cr-Commit-Position: refs/heads/master@{#373585}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M tools/perf/docs/perf_regression_sheriffing.md View 1 2 3 chunks +24 lines, -24 lines 1 comment Download

Messages

Total messages: 11 (6 generated)
mustaq
ptal https://codereview.chromium.org/1663673005/diff/40001/tools/perf/docs/perf_regression_sheriffing.md File tools/perf/docs/perf_regression_sheriffing.md (left): https://codereview.chromium.org/1663673005/diff/40001/tools/perf/docs/perf_regression_sheriffing.md#oldcode33 tools/perf/docs/perf_regression_sheriffing.md:33: * If the alert appears to be **within ...
4 years, 10 months ago (2016-02-04 17:38:17 UTC) #4
sullivan
lgtm
4 years, 10 months ago (2016-02-04 17:39:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663673005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663673005/40001
4 years, 10 months ago (2016-02-04 17:40:37 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 19:24:16 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 19:25:12 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5527f553b5f37b3bf74bfb16c874bc0aa2c86cff
Cr-Commit-Position: refs/heads/master@{#373585}

Powered by Google App Engine
This is Rietveld 408576698