extend gm to test aa[] parameter on xfer4f procs

extend gm to test aa[] parameter on xfer4f procs

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663643002

Committed: https://skia.googlesource.com/skia/+/ef5252e48ff6c5ed2b53b87333b7ed716c8b9035

[reed1, 2016-02-03 00:34:54]

Description was changed from

==========
extend gm to test aa[] parameter on xfer4f procs

BUG=skia:
==========

to

==========
extend gm to test aa[] parameter on xfer4f procs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-02-03 00:35:09]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 00:36:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/1

[commit-bot: I haz the power, 2016-02-03 00:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 00:59:00]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-03 01:20:37]

reed@google.com changed reviewers:
+ herb@google.com, mtklein@google.com

[reed1, 2016-02-03 01:20:37]

as I suspected, if you don't test it (aa code path), it'll have bugs.

[reed1, 2016-02-03 01:20:46]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 01:20:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/20001

[mtklein, 2016-02-03 01:32:56]

https://codereview.chromium.org/1663643002/diff/20001/src/core/SkXfermode4f.cpp
File src/core/SkXfermode4f.cpp (right):

https://codereview.chromium.org/1663643002/diff/20001/src/core/SkXfermode4f.c...
src/core/SkXfermode4f.cpp:279: Sk4f s4_aa = scale_by_coverage(s4, a);
Ah!  Let's make s4 and dst_scale const?

I guarantee the compiler will allocate registers as well as we can manually if
you just always give each new value a new name.  All the good ones give each new
value a new name internally anyway (this is "SSA" form, single static
assignment).

[commit-bot: I haz the power, 2016-02-03 01:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 01:47:59]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-03 02:57:59]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 02:58:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/40001

[reed1, 2016-02-03 03:07:21]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 03:07:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/60001

[commit-bot: I haz the power, 2016-02-03 03:09:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 03:09:35]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-02-03 03:19:49]

https://codereview.chromium.org/1663643002/diff/20001/src/core/SkXfermode4f.cpp
File src/core/SkXfermode4f.cpp (right):

https://codereview.chromium.org/1663643002/diff/20001/src/core/SkXfermode4f.c...
src/core/SkXfermode4f.cpp:279: Sk4f s4_aa = scale_by_coverage(s4, a);
On 2016/02/03 01:32:55, mtklein wrote:
> Ah!  Let's make s4 and dst_scale const?
> 
> I guarantee the compiler will allocate registers as well as we can manually if
> you just always give each new value a new name.  All the good ones give each
new
> value a new name internally anyway (this is "SSA" form, single static
> assignment).

ok

[reed1, 2016-02-03 03:19:58]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 03:20:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/80001

[commit-bot: I haz the power, 2016-02-03 03:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 03:22:36]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-02-03 03:39:42]

will follow-up this with optimizations after this lands

[reed1, 2016-02-03 14:49:12]

ohter comments?

[mtklein, 2016-02-03 14:51:28]

lgtm

https://codereview.chromium.org/1663643002/diff/80001/src/core/SkXfermode4f.cpp
File src/core/SkXfermode4f.cpp (right):

https://codereview.chromium.org/1663643002/diff/80001/src/core/SkXfermode4f.c...
src/core/SkXfermode4f.cpp:322: Sk4f s4_aa = scale_by_coverage(s4, a);
Probably want const s4/dst_scale here too?

[reed1, 2016-02-03 15:01:12]

https://codereview.chromium.org/1663643002/diff/80001/src/core/SkXfermode4f.cpp
File src/core/SkXfermode4f.cpp (right):

https://codereview.chromium.org/1663643002/diff/80001/src/core/SkXfermode4f.c...
src/core/SkXfermode4f.cpp:322: Sk4f s4_aa = scale_by_coverage(s4, a);
On 2016/02/03 14:51:28, mtklein wrote:
> Probably want const s4/dst_scale here too?

Done.

[reed1, 2016-02-03 15:01:15]

The CQ bit was checked by reed@google.com

[reed1, 2016-02-03 15:01:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1663643002/#ps100001
(title: "make another const")

[commit-bot: I haz the power, 2016-02-03 15:01:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/100001

[commit-bot: I haz the power, 2016-02-03 15:13:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-03 15:13:28]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-02-03 16:00:43]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-03 16:00:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/120001

[reed1, 2016-02-03 16:01:52]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-02-03 16:01:55]

The CQ bit was checked by reed@google.com

[reed1, 2016-02-03 16:01:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1663643002/#ps120001
(title: "don't pass bad flags to factory")

[commit-bot: I haz the power, 2016-02-03 16:02:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1663643002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1663643002/120001

[commit-bot: I haz the power, 2016-02-03 17:47:49]

Description was changed from

==========
extend gm to test aa[] parameter on xfer4f procs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
extend gm to test aa[] parameter on xfer4f procs

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ef5252e48ff6c5ed2b53b87333b7ed716c8b9035
==========

[commit-bot: I haz the power, 2016-02-03 17:47:49]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/ef5252e48ff6c5ed2b53b87333b7ed716c8b9035