Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 166363002: Use the current default capture for the webaudio track to get the correct delay value (Closed)

Created:
6 years, 10 months ago by no longer working on chromium
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use the current default capture for the webaudio audio track to get the correct delay value. The source of the webaudio audio track might not have any capturer and this will make |need_audio_processing| flag to be false. BUG=343866 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251362

Patch Set 1 #

Patch Set 2 : new solution, ready for review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
no longer working on chromium
Tommi, please review.
6 years, 10 months ago (2014-02-14 11:11:56 UTC) #1
tommi (sloooow) - chröme
lgtm. Please add an issue number if one exists.
6 years, 10 months ago (2014-02-14 11:55:07 UTC) #2
no longer working on chromium
On 2014/02/14 11:55:07, tommi wrote: > lgtm. Please add an issue number if one exists. ...
6 years, 10 months ago (2014-02-14 12:05:57 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 10 months ago (2014-02-14 12:06:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/166363002/80002
6 years, 10 months ago (2014-02-14 12:06:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 14:23:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202248
6 years, 10 months ago (2014-02-14 14:23:35 UTC) #7
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 10 months ago (2014-02-14 16:09:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/166363002/80002
6 years, 10 months ago (2014-02-14 16:11:10 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 17:24:27 UTC) #10
Message was sent while issue was closed.
Change committed as 251362

Powered by Google App Engine
This is Rietveld 408576698