Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1663623002: NEON optimizations for GrayAlpha -> RGBA/BGRA Premul/Unpremul (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gralpha
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

NEON optimizations for GrayAlpha -> RGBA/BGRA Premul/Unpremul PNG Decode Time Nexus 6P (for a test set of GrayAlpha encoded PNGs) Regular Unpremul 0.91x Zero Init Unpremul 0.92x Regular Premul 0.84x Zero Init Premul 0.86x BUG=skia:4767 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663623002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/1e06079b259d1091b735492b2f71d9897c14c608

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -19 lines) Patch
M src/codec/SkSwizzler.cpp View 3 chunks +32 lines, -0 lines 0 comments Download
M src/core/SkOpts.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkOpts.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/opts/SkOpts_ssse3.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/opts/SkSwizzler_opts.h View 1 4 chunks +106 lines, -0 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
msarett
These improvements are in addition to the speed-up from the CL that this depends on. ...
4 years, 10 months ago (2016-02-03 00:35:42 UTC) #4
mtklein
lgtm https://codereview.chromium.org/1663623002/diff/20001/src/opts/SkSwizzler_opts.h File src/opts/SkSwizzler_opts.h (right): https://codereview.chromium.org/1663623002/diff/20001/src/opts/SkSwizzler_opts.h#newcode346 src/opts/SkSwizzler_opts.h:346: uint8x16x2_t ga = vld2q_u8(src); We sure are getting ...
4 years, 10 months ago (2016-02-03 01:08:15 UTC) #5
msarett
https://codereview.chromium.org/1663623002/diff/20001/src/opts/SkSwizzler_opts.h File src/opts/SkSwizzler_opts.h (right): https://codereview.chromium.org/1663623002/diff/20001/src/opts/SkSwizzler_opts.h#newcode346 src/opts/SkSwizzler_opts.h:346: uint8x16x2_t ga = vld2q_u8(src); On 2016/02/03 01:08:15, mtklein wrote: ...
4 years, 10 months ago (2016-02-03 14:48:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663623002/20001
4 years, 10 months ago (2016-02-03 18:47:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 19:17:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1e06079b259d1091b735492b2f71d9897c14c608

Powered by Google App Engine
This is Rietveld 408576698