runtime/vm/native_entry.h - Issue 1663613002: Dart_SetReturnValue now accepts and propagates error handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 1663613002: Dart_SetReturnValue now accepts and propagates error handles. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/native_entry.h

diff --git a/runtime/vm/native_entry.h b/runtime/vm/native_entry.h

index e9dab6cdef16a3653cb7acc11a861c52b2333d3c..c5578f92635e9cd21368785136c8eb8c4a178ffb 100644

--- a/runtime/vm/native_entry.h

+++ b/runtime/vm/native_entry.h

@@ -121,6 +121,9 @@ class NativeEntry : public AllStatic {

static uword LinkNativeCallEntry();

static void LinkNativeCall(Dart_NativeArguments args);

+ private:

+ static bool ReturnValueIsError(NativeArguments* arguments);

+ static void PropagateErrors(NativeArguments* arguments);

};

} // namespace dart

« no previous file with comments | « runtime/vm/native_arguments.h ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »