Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1663543003: [regexp] fix zero-length matches for RegExp.prototype.@@split. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix zero-length matches for RegExp.prototype.@@split. BUG=v8:4717 LOG=N Committed: https://crrev.com/aff7bd54beb74a6effba330ea940d3ee31d9717f Cr-Commit-Position: refs/heads/master@{#33706}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/js/regexp.js View 1 2 chunks +14 lines, -1 line 0 comments Download
M test/mjsunit/harmony/unicode-regexp-zero-length.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yang
4 years, 10 months ago (2016-02-03 11:32:05 UTC) #2
Toon Verwaest
lgtm with comment https://codereview.chromium.org/1663543003/diff/1/src/js/regexp.js File src/js/regexp.js (right): https://codereview.chromium.org/1663543003/diff/1/src/js/regexp.js#newcode300 src/js/regexp.js:300: if (index + 1 > subject.length) ...
4 years, 10 months ago (2016-02-03 13:11:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663543003/20001
4 years, 10 months ago (2016-02-03 14:24:31 UTC) #6
Yang
Thanks for catching this. Fixed.
4 years, 10 months ago (2016-02-03 14:29:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 14:48:38 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 14:49:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aff7bd54beb74a6effba330ea940d3ee31d9717f
Cr-Commit-Position: refs/heads/master@{#33706}

Powered by Google App Engine
This is Rietveld 408576698