base/trace_event/process_memory_maps.cc - Issue 1663533005: [tracing] Support shared and private permission. (missing perm flag)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/process_memory_maps.cc

Issue 1663533005: [tracing] Support shared and private permission. (missing perm flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/process_memory_maps.h ('K') | « base/trace_event/process_memory_maps.h ('k') | components/tracing/process_metrics_memory_dump_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/process_memory_maps.cc

diff --git a/base/trace_event/process_memory_maps.cc b/base/trace_event/process_memory_maps.cc

index 31083a892773ad3fb268ecadfaa247c18b5fffaf..9fbee95c9029642be6f347b6d24afecbdd8ed983 100644

--- a/base/trace_event/process_memory_maps.cc

+++ b/base/trace_event/process_memory_maps.cc

@@ -15,6 +15,7 @@ namespace trace_event {

const uint32_t ProcessMemoryMaps::VMRegion::kProtectionFlagsRead = 4;

const uint32_t ProcessMemoryMaps::VMRegion::kProtectionFlagsWrite = 2;

const uint32_t ProcessMemoryMaps::VMRegion::kProtectionFlagsExec = 1;

+const uint32_t ProcessMemoryMaps::VMRegion::kProtectionFlagsMayShare = 80;

Primiano Tucci (use gerrit) 2016/02/05 09:32:39 80 ?? I guess you meant 8

petrcermak 2016/02/05 11:18:56 nit: Is there a reason why these are not sorted in

petrcermak 2016/02/05 11:21:34 Also, could you please provide a link to some docu

Primiano Tucci (use gerrit) 2016/02/11 13:51:48 yeah, this is either 0x80 or 128 but definitely no

ProcessMemoryMaps::VMRegion::VMRegion()

: start_address(0),

« base/trace_event/process_memory_maps.h ('K') | « base/trace_event/process_memory_maps.h ('k') | components/tracing/process_metrics_memory_dump_provider.cc » ('j') | no next file with comments »