Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1663533003: Fix zero-sized blur with crop rect. (Closed)

Created:
4 years, 10 months ago by Stephen White
Modified:
4 years, 10 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m49
Target Ref:
refs/heads/chrome/m49
Project:
skia
Visibility:
Public.

Description

Fix zero-sized blur with crop rect. [Cherry-pick of 6404981b0c3984ba91b3bda35e60c6c8a8a773c2 to chrome/m49.] Neither the GPU nor CPU paths were correctly handling the crop rect in this case. NOTE: this change adds a new test case to the imageblurcropped GM, so it will have to be rebaselined. BUG=skia:4876 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657773002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/3a2b4d5906625f5178e6da69c1f62ab4e6f275e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M gm/imagefilterscropped.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 5 chunks +28 lines, -22 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Stephen White
4 years, 10 months ago (2016-02-03 14:38:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a2b4d5906625f5178e6da69c1f62ab4e6f275e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698