Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 166353002: Media Galleries: Refactor media scan worker function into a worker class. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Media Galleries: Refactor media scan worker function into a worker class. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251504

Patch Set 1 : #

Total comments: 2

Patch Set 2 : use a struct #

Patch Set 3 : fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -106 lines) Patch
M chrome/browser/media_galleries/media_folder_finder.h View 1 2 5 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/media_galleries/media_folder_finder.cc View 1 2 7 chunks +101 lines, -93 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 10 months ago (2014-02-14 09:40:22 UTC) #1
vandebo (ex-Chrome)
LGTM after comment. https://codereview.chromium.org/166353002/diff/30001/chrome/browser/media_galleries/media_folder_finder.h File chrome/browser/media_galleries/media_folder_finder.h (right): https://codereview.chromium.org/166353002/diff/30001/chrome/browser/media_galleries/media_folder_finder.h#newcode44 chrome/browser/media_galleries/media_folder_finder.h:44: typedef std::pair<MediaGalleryScanResult, std::vector<base::FilePath> > Please use ...
6 years, 10 months ago (2014-02-14 17:11:51 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-14 20:59:18 UTC) #3
Lei Zhang
https://codereview.chromium.org/166353002/diff/30001/chrome/browser/media_galleries/media_folder_finder.h File chrome/browser/media_galleries/media_folder_finder.h (right): https://codereview.chromium.org/166353002/diff/30001/chrome/browser/media_galleries/media_folder_finder.h#newcode44 chrome/browser/media_galleries/media_folder_finder.h:44: typedef std::pair<MediaGalleryScanResult, std::vector<base::FilePath> > On 2014/02/14 17:11:51, vandebo wrote: ...
6 years, 10 months ago (2014-02-14 20:59:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/166353002/70001
6 years, 10 months ago (2014-02-14 21:10:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 22:16:15 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-14 22:16:15 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-14 23:04:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/166353002/290002
6 years, 10 months ago (2014-02-14 23:07:56 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:56:27 UTC) #10
Message was sent while issue was closed. 
Change committed as 251504

Powered by Google App Engine
This is Rietveld 408576698