Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issue 1663513004: Increase max vertex attrib count in GrPrimitiveProcessor (Closed)

Created:
4 years, 10 months ago by Chris Dalton
Modified:
4 years, 10 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Increase max vertex attrib count in GrPrimitiveProcessor Increases the max vertex attrib count in GrPrimitiveProcessor from 6 to 8. This is the required minimum by ES 2.0 for GL_MAX_VERTEX_ATTRIBS. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663513004 Committed: https://skia.googlesource.com/skia/+/e3fafcf7d1e236a55f9589697a4598e11749405e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrPrimitiveProcessor.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Chris Dalton
4 years, 10 months ago (2016-02-03 20:55:10 UTC) #3
egdaniel
lgtm
4 years, 10 months ago (2016-02-03 21:12:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663513004/1
4 years, 10 months ago (2016-02-03 21:13:34 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663513004/1
4 years, 10 months ago (2016-02-03 21:19:13 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 21:45:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663513004/1
4 years, 10 months ago (2016-02-03 22:02:13 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:02:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e3fafcf7d1e236a55f9589697a4598e11749405e

Powered by Google App Engine
This is Rietveld 408576698