Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1663453002: Test CodecImageGenerator on GPU bots (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Test CodecImageGenerator on GPU bots In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes, so that we can test on a GPU bot. Update the arguments to DM so that we run CodecImageGenerator on GPU bots. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663453002 Committed: https://skia.googlesource.com/skia/+/c9715406c4c9c995e5661a4ea2188fb8643845c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M tools/dm_flags.json View 7 chunks +7 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scroggo
4 years, 10 months ago (2016-02-02 19:29:41 UTC) #3
msarett
lgtm
4 years, 10 months ago (2016-02-02 20:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663453002/1
4 years, 10 months ago (2016-02-03 13:56:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c9715406c4c9c995e5661a4ea2188fb8643845c0
4 years, 10 months ago (2016-02-03 14:23:12 UTC) #8
jcgregorio
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1663143002/ by jcgregorio@google.com. ...
4 years, 10 months ago (2016-02-03 16:30:37 UTC) #9
scroggo
4 years, 10 months ago (2016-02-09 13:10:45 UTC) #11
Message was sent while issue was closed. 
On 2016/02/03 16:30:37, jcgregorio wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1663143002/ by mailto:jcgregorio@google.com.
> 
> The reason for reverting is: Failures:
> D/skia    ( 3581): 	gpu image gen frame_larger_than_image.gif: Could not
create
> a surface.
> D/skia    ( 3581): 	gpu image gen offsets_too_large.gif: Could not create a
> surface.
> D/skia    ( 3581): 	gpu image gen PANO_20121023_214540.jpg: Could not create a
> surface.
> D/skia    ( 3581): 	gpu image gen interlaced1.png: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen interlaced2.png: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen interlaced3.png: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Canon_5D2.dng: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Fuji_X20.dng: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen HTC.dng: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen lg_g4_iso_800.dng: Could not create a
surface.
> D/skia    ( 3581): 	gpu image gen Canon_G7X.CR2: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Pentax_K5.DNG: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Nikon_1AW1.NEF: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Nikon_1J4.NEF: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Nikon_P330.NRW: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Olympus_E-PL3.ORF: Could not create a
surface.
> D/skia    ( 3581): 	gpu image gen Olympus_PL7.ORF: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Pentax_K5.PEF: Could not create a surface.
> D/skia    ( 3581): 	gpu image gen Samsung_NX3000.SRW: Could not create a
> surface..

Relanded in crrev.com/1676663002

Powered by Google App Engine
This is Rietveld 408576698