Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1663433002: Adds an interface to SurfaceHittestDelegate in order to override (Closed)

Created:
4 years, 10 months ago by lfg
Modified:
4 years, 10 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds an interface to SurfaceHittestDelegate in order to override the hittesting decision to accept a surface. This will be used to override hittesting on transparent backgrounds. BUG=491334 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d Cr-Commit-Position: refs/heads/master@{#374433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -75 lines) Patch
M cc/surfaces/surface_hittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/surfaces/surface_hittest_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 2 chunks +67 lines, -63 lines 0 comments Download
M cc/test/surface_hittest_test_helpers.h View 1 chunk +12 lines, -5 lines 0 comments Download
M cc/test/surface_hittest_test_helpers.cc View 1 chunk +27 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
lfg
Hi John, please take a look.
4 years, 10 months ago (2016-02-02 18:13:45 UTC) #3
lfg
On 2016/02/02 18:13:45, lfg wrote: > Hi John, please take a look. Ping.
4 years, 10 months ago (2016-02-08 22:14:07 UTC) #4
jbauman
lgtm
4 years, 10 months ago (2016-02-08 22:41:17 UTC) #5
lfg
piman@chromium.org: Please review changes in content/, cc/test/
4 years, 10 months ago (2016-02-08 22:45:33 UTC) #7
piman
lgtm
4 years, 10 months ago (2016-02-09 00:24:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663433002/1
4 years, 10 months ago (2016-02-09 16:30:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 20:11:16 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:12:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a24ca73f36d6b45f7743328e36f6382fd5cee4d
Cr-Commit-Position: refs/heads/master@{#374433}

Powered by Google App Engine
This is Rietveld 408576698