Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 166343004: A64: Improve the deoptimization helpers to generate fewer instructions. (Closed)

Created:
6 years, 10 months ago by Alexandre Rames
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Improve the deoptimization helpers to generate fewer instructions. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19516

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge DeoptimizeHeader into DeoptimizeBranch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -66 lines) Patch
M src/a64/lithium-codegen-a64.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 6 chunks +31 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexandre Rames
6 years, 10 months ago (2014-02-19 16:14:56 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/166343004/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/166343004/diff/1/src/a64/lithium-codegen-a64.cc#newcode1012 src/a64/lithium-codegen-a64.cc:1012: int bit) { it should be possible to merge ...
6 years, 10 months ago (2014-02-19 16:22:47 UTC) #2
Alexandre Rames
https://codereview.chromium.org/166343004/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/166343004/diff/1/src/a64/lithium-codegen-a64.cc#newcode1012 src/a64/lithium-codegen-a64.cc:1012: int bit) { On 2014/02/19 16:22:47, jochen wrote: > ...
6 years, 10 months ago (2014-02-19 17:20:29 UTC) #3
jochen (gone - plz use gerrit)
can you upload the new patchset please?
6 years, 10 months ago (2014-02-20 08:22:26 UTC) #4
Alexandre Rames
On 2014/02/20 08:22:26, jochen wrote: > can you upload the new patchset please? Yes it's ...
6 years, 10 months ago (2014-02-20 08:23:39 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-20 12:53:19 UTC) #6
Alexandre Rames
6 years, 10 months ago (2014-02-20 16:41:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r19516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698